From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yFmnLKw4a2WNQQEA9RJhRA:P1 (envelope-from ) for ; Sat, 02 Dec 2023 15:01:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yFmnLKw4a2WNQQEA9RJhRA (envelope-from ) for ; Sat, 02 Dec 2023 15:01:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9733544BDA for ; Sat, 2 Dec 2023 15:01:16 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=MWCzyxhP; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701525676; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=myHxxtlW3lKv8Nk4JtGBS3Mvff3WMeGdAGXexcVKZF0=; b=k/C0GppnqlRrEO++5Nc4t6OqlreiQxi/N2BGq0L7zgpIipQIRlgQVAqzxP8JYKJNhUGSub qxEdoVptngvgkOfo7+UhORzb4vy3sjh1f3P6pIF2IUCu1KUpWjeTsfmdZxAo+Qoii8eEbP z4ooTGzrOde85kgTVZsGjz6CUwEjONfzWc79IgPDyNlsnnuKQH9t3lPdJRa/yA/4D/27Tt b8j5g6P/aumgH/52wl36Cm7a84kH6I2VOzCevaVvdC0J8jzI+XPPsa3w4+MgL1S2qMN+k8 4RHMWA//xbZuqsgc0nznQ2i2FK/4yVcq1wj0IRYt8vYbojcLGh6+bdPAt/zj4A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701525676; a=rsa-sha256; cv=none; b=VfLB94XPNwsdAAOxv7sglabf1DFP4mHYthMFSkH5wUARV4SNFfKcdu+jL15WcuKq5Vo2aG Wj4EQFsNN0x+Y9GDmo6MZEbxs6OJjBctNgwzUGhnRiy1o+VwpUBfr6XzrGkXFFCYqHSiT6 w1tC1CgRE6Rjweb2syJiAR/iSG6jZTATUBnk0uAxHfvzOE2f7C+SQ+T98D4ZXb4EWu0g8f vdKb2EFYf6l+6MaYl0W03WgXCerI8JZ1FsPfOb04FE4iFRgwKMYxtWwNkTjpelMEL//tPF 5n94k+XZKehdHOJXOk/M8AKUVPZqtwQyccDPOWPV6wQo/2n9taniXPURtXToZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=MWCzyxhP; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9QYB-00032A-5X; Sat, 02 Dec 2023 09:00:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9QY8-000317-Py for guix-patches@gnu.org; Sat, 02 Dec 2023 09:00:52 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9QY8-0006ZF-D6 for guix-patches@gnu.org; Sat, 02 Dec 2023 09:00:52 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9QYH-00089g-MT for guix-patches@gnu.org; Sat, 02 Dec 2023 09:01:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66961] [PATCH v3] scripts: hash: Handle repository with different VCS folders. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Dec 2023 14:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66961 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Mathieu Othacehe , Tobias Geerinckx-Rice , 66961@debbugs.gnu.org, Ricardo Wurmus , Christopher Baines Received: via spool by 66961-submit@debbugs.gnu.org id=B66961.170152560931252 (code B ref 66961); Sat, 02 Dec 2023 14:01:01 +0000 Received: (at 66961) by debbugs.gnu.org; 2 Dec 2023 14:00:09 +0000 Received: from localhost ([127.0.0.1]:56938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9QXQ-00087z-R4 for submit@debbugs.gnu.org; Sat, 02 Dec 2023 09:00:09 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:39185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9QXO-00085o-N8 for 66961@debbugs.gnu.org; Sat, 02 Dec 2023 09:00:07 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40b4ff0f254so4239225e9.1 for <66961@debbugs.gnu.org>; Sat, 02 Dec 2023 05:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701525591; x=1702130391; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=myHxxtlW3lKv8Nk4JtGBS3Mvff3WMeGdAGXexcVKZF0=; b=MWCzyxhPglnWA7k88pXBu4j8m67g2Pw5JRf0+5vLgfEen7MJ7WiJiOD7OtCdgc2oGG K7dq9qfidMQKaqxt+VAr7X0bkFcztccpTT+0sOIEj5HL9kOG5wpqcF2PeWiOUzqLTuxv +lsJuB85bx6CKvfe3FgMNyMCWZAp+4YWmrJ9ekPbYm1h5qpejFmDsGG7sdi2YSs/WCrh JIbHnoz97Me1FJ1GQWrap1M3R8XfkQBu0bE6gjiDkQwFMNSVfM+BfbItStRXPThUDDqE bny29U5AOJPy9tEPhHAIZzvunjhsjjHNEj5rkZdQfsd0z2RsOhnqgwDzYeA8DvWt6g9B Lviw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701525591; x=1702130391; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=myHxxtlW3lKv8Nk4JtGBS3Mvff3WMeGdAGXexcVKZF0=; b=bq7uSEefz9wV+UciSCWDxm4NV02AbaQat5uGYg21SDZWEsO3mC/vBN/VAdhlruq1cx 4hJZqDtqRQ4un9VsRyF8s8Id3DF72Vn2TqQiykOPi5NkoD7st01eDX1Uy7nCjYHzYOzW ebkLG7HW7Hd/qP4pzLIIROk3OyGE9xYhmEqD0PvPW3CxxgTI0gxov+0X5YVfrDiJt4ZS fWo1EaLVYyB7GaAHPFGbUCHhnjo2eJewTucJCX+TbYAhgtZkvJWFI0NtgxmYl0FpegpJ muYIgWu2eIDs51Ce3yc4QwTMXXgwmazLDWALdfM+/RSE4B6FZOV6VPdP95weaUaV6rES mNug== X-Gm-Message-State: AOJu0Ywu/HuJosBfwKFZuZdfwNd6OhJD50++mGGF+4xVEJQyUwq0UBoG 0kzkRzwPig1coTWuxw9PAfI= X-Google-Smtp-Source: AGHT+IFC1u+k+9A/rt4ZArtZaczk3MK60BIKmNCtBRThffadqYy3kc1vJWMSPWJnIKJoFUgjkOaixw== X-Received: by 2002:a05:600c:1c97:b0:3fe:d637:7b25 with SMTP id k23-20020a05600c1c9700b003fed6377b25mr5582744wms.0.1701525591278; Sat, 02 Dec 2023 05:59:51 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:7e06:4c1e:3607:79b6]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c4f4800b0040b37f107c4sm8810641wmq.16.2023.12.02.05.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 05:59:50 -0800 (PST) From: Simon Tournier In-Reply-To: <87ttp0hoqw.fsf@gnu.org> References: <4be63ddf12bd6143b43e87951e164dc93c585bb8.1699225200.git.zimon.toutoune@gmail.com> <6a560e37ba23e43d35c0b62c1ee860b4341c263c.1701290895.git.zimon.toutoune@gmail.com> <87ttp0hoqw.fsf@gnu.org> Date: Sat, 02 Dec 2023 14:10:24 +0100 Message-ID: <87o7f8rbr3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -3.34 X-Spam-Score: -3.34 X-Migadu-Queue-Id: 9733544BDA X-TUID: jGDunnhfR3WL Hi, On sam., 02 d=C3=A9c. 2023 at 11:39, Ludovic Court=C3=A8s wr= ote: > Nitpick: I would call it =E2=80=98vcs-file-predicate=E2=80=99 for consist= ency, Hum, I thought the convention for =E2=80=99predicate=E2=80=99 was ending by= =E2=80=99?=E2=80=99. Therefore, personally I do not find this name consistent. Anyway=E2=80=A6 > with > a docstring along these lines: > > Return a two-argument procedure that returns true for version-control > metadata directories such as '.git' found in DIRECTORY. =E2=80=A6did that way in v4. Thanks for your comments. Cheers, simon