From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id UISOMw1j22XJgQEA62LTzQ:P1 (envelope-from ) for ; Sun, 25 Feb 2024 16:55:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UISOMw1j22XJgQEA62LTzQ (envelope-from ) for ; Sun, 25 Feb 2024 16:55:57 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=4szPKMKe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708876557; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Egv2ZyeDVWXK5PEPos0Ll5pqR+7rKvkxhRK/yFg75qE=; b=VQk20WVzEOsQGj3N3ZBa24wRgDlcjhXffVVVN56dZ5wlpfD2Wcgb7r3+ri/ZTJipD2nW9l QWnUOzmzXF23UfGXuOuHmptHhdx4LoD5Aezdso+hc6dxlKZFyUSmcspsbi0L22B8S5v7pm Vi2fUDlYTnMPSj/3io2sS7GK20xQTwUHhObjRO4In3EmO0TF7lRzfCza2/lhE6l9RvCobz sjtO9ua4/39GSVWj4qJD+EP/pZibgdu8mYw9JYWDLXT+e5eLz6g8XD62U24tUMAfhXvZPX ik3shgCfvX2XdRmBVulgdDJkUQbi+iCnXNKD9ed/CY5dAAYt4xlf7hchpqA5Mg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=4szPKMKe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708876557; a=rsa-sha256; cv=none; b=h3Snbqmf030TohHUOhV2uoI2ggPaWerRK7biJLX45E49DyMAgOovzHkM/uTlMRuXci3Ep7 dbN7MbAx9RtLKErYUWWLpvJalVbCixXdoUW24Ft3OsfnjoVDzxtAGwtFt9Rppz+Q4igX5J BCIVngUpoqZ6cNrqsh5i9l37TCaRJ2yhNIJssT095zzgfunaQsIcX2jFGRlxd/EDR8lebS GZNoCLaMHcsX0m81rbYMREBMaX94968CkBd7MPgf57xu1UZjzcyM9ynPKIlNyL3S1rBzDe 8dakK5Ohd7LDqSZb3vLoYyWHIqBrO88V1EknqteMtOpRibPSyux2qFJRz3y2RQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5FB4C301AF for ; Sun, 25 Feb 2024 16:55:57 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reGqq-0003I5-Ou; Sun, 25 Feb 2024 10:55:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reGqo-0003HZ-Do for guix-patches@gnu.org; Sun, 25 Feb 2024 10:55:38 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reGqo-0000Am-57 for guix-patches@gnu.org; Sun, 25 Feb 2024 10:55:38 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1reGrC-0007Hs-AX for guix-patches@gnu.org; Sun, 25 Feb 2024 10:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69377] [PATCH] gnu: Add sioyek. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 25 Feb 2024 15:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69377 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dan Cc: 69377@debbugs.gnu.org Received: via spool by 69377-submit@debbugs.gnu.org id=B69377.170887652227892 (code B ref 69377); Sun, 25 Feb 2024 15:56:02 +0000 Received: (at 69377) by debbugs.gnu.org; 25 Feb 2024 15:55:22 +0000 Received: from localhost ([127.0.0.1]:55221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reGqU-0007Fe-IL for submit@debbugs.gnu.org; Sun, 25 Feb 2024 10:55:22 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:46878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reGpl-0007D2-FB for 69377@debbugs.gnu.org; Sun, 25 Feb 2024 10:54:35 -0500 Date: Sun, 25 Feb 2024 23:53:33 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1708876433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Egv2ZyeDVWXK5PEPos0Ll5pqR+7rKvkxhRK/yFg75qE=; b=4szPKMKeIKgrBgjyx78hhZTISZOu4akSgyfnNElUYQFmHToN5CQn89WnX49YdroRUy0N3M zSVY7dTwU75Tal9cH20TPyosOCGP+GoakmUvNnJAakO6L8wj8JWaTL2+c8t8TuBam9b1NJ SncYJ076DLxrUXNjv9k0d/z8zB8oltBpYJ4dGyvX/OwRUIYoz7CaK0bn1Db916a+NhFbJs OQ0V39Yx7LFhPrA9kV3Vnw6ZjIXoyg2O18XAl/T9+NatC32qiJfUp53NkPToUC1a9ug7Lq YCKGpzqkGK8YJCG3Z5jlCXLoHhOIMwu+F9y3JB2pClKv9UmVx0k00Tk4wuM3uQ== Message-ID: <87o7c4sfpe.wl-hako@ultrarare.space> In-Reply-To: <20240225101233.13418-1-i@dan.games> References: <20240225101233.13418-1-i@dan.games> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.77 X-Spam-Score: -6.77 X-Migadu-Queue-Id: 5FB4C301AF X-TUID: TbUCZ88IeYsF Hi dan, On Sun, 25 Feb 2024 18:12:32 +0800, dan wrote: > > * gnu/packages/pdf.scm (sioyek): New variable. > > Change-Id: Id2708745bd7ef672b620b8e9c907126bdc5a1f55 > --- > gnu/packages/pdf.scm | 67 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm > index 0d796f65bb..587c952e37 100644 > --- a/gnu/packages/pdf.scm > +++ b/gnu/packages/pdf.scm > @@ -25,6 +25,7 @@ > ;;; Copyright =A9 2022 Paul A. Patience > ;;; Copyright =A9 2022 Petr Hodina > ;;; Copyright =A9 2023 Felix Gruber > +;;; Copyright =A9 2024 dan > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -1710,3 +1711,69 @@ (define-public weasyprint > > Keywords: html2pdf, htmltopdf") > (license license:bsd-3))) > + > +(define-public sioyek > + (package > + (name "sioyek") > + (version "2.0.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ahrm/sioyek.git") Please remove the =A1.git=A2 suffix, in GitHub it's used for redirection. > + (commit (string-append "v" version)))) > + (sha256 > + (base32 "1vmmp2s032ygh1byz77pg9aljmp8hx745fr7mmz11831f96mlmhq")) > + ;; XXX: Fix for mupdf-0.23.0+ . > + (patches (list (origin > + (method url-fetch) > + (uri (string-append > + "https://git.alpinelinux.org/aports/plain/= community" > + "/sioyek/mupdf-0.23.0.patch?id=3D" > + "86e913eccf19b97a16f25d9b6cdf0f50232f1226"= )) > + (sha256 (base32 > + "0wddl7qznr7x9kmqjb05f9pag8m4w29bnnw8gh= zsi1zz9ska2jmh"))))))) Please add the patch (with attribution) under gnu/packages/patches instead. =A1file-name=A2 field is missing, by the way. > + (build-system gnu-build-system) > + (arguments > + (list > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'patch-lib-and-path > + (lambda _ > + (substitute* "pdf_viewer_build_config.pro" > + (("-lmupdf-third") > + "") Removing =A1-lmupdf-third=A2 can be added as a source snippet. > + (("/share/sioyek") > + "/share") > + (("/etc/sioyek") > + "/etc")) > + (substitute* "pdf_viewer/main.cpp" > + (("/usr/share/sioyek") > + (string-append #$output "/share")) > + (("/etc/sioyek") > + (string-append #$output "/etc"))))) Please keep /etc/sioyek and /share/sioyek, think where files will be when installed into a profile. > + (replace 'configure > + (lambda _ > + (invoke "qmake" > + (string-append "PREFIX=3D" > + #$output)))) This =A1PREFIX=A2 can be added to =A1#:configure-flags=A2. > + (add-after 'install 'instal-man-page > + (lambda _ > + (install-file "resources/sioyek.1" > + (string-append #$output "/share/man= /man1"))))))) > + (inputs (list freetype > + gumbo-parser > + harfbuzz > + jbig2dec > + libjpeg-turbo > + mujs > + mupdf > + openjpeg > + qt3d-5 > + qtbase-5 > + zlib)) > + (home-page "https://sioyek.info") > + (synopsis > + "A PDF viewer with a focus on technical books and research papers") Don't use an article at the beginning of synopsis. > + (description > + "Sioyek is a PDF viewer with a focus on textbooks and research pape= rs.") > + (license license:gpl3+))) > > base-commit: 1306beaf3f6c8ddded2a956f5863bc65aad78882 > -- > 2.41.0 Otherwise LGTM, please send a revised patch. Thanks