From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id +KivCS/4RGaiYAAAqHPOHw:P1 (envelope-from ) for ; Wed, 15 May 2024 20:00:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id +KivCS/4RGaiYAAAqHPOHw (envelope-from ) for ; Wed, 15 May 2024 20:00:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b="V9/rA+/1"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715796015; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=twBIF3bBnXsueJE01EvcNKjJBtB3qP9ZHr+URzoGXTs=; b=m+VyQohY7E8KszeCvSml1YSr5wjiv2+9+s1e9fRuuPmwbVNYwd50jLGviN5OvPU7yBj1rk EZXoXwST0nMc5ZC9bJfN8Qp/OazxGgQTXLWj6PAo3d6T1pUdGWgvhzABDBpdhh1Yt38Ecg 57MEMr4NgzMp8juYLzPwF2Hw5dfCyLv+4PyZZy3pIDMWDWc64x/V7ClF+fXMgWdbkEHD6g aD0P+0ZPJXCJvn+MyRAhcUcZPiFUn+trbw7RwmlMZMWet8ptqZjJZogTUO5mPB/9+ozsu0 6pQWdUh6zWrb9EwPe91jAyRTpMl8pmmsbAyV2GlJHrrznTHhYvL7qWdUYzeeLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b="V9/rA+/1"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715796015; a=rsa-sha256; cv=none; b=Hxz8AS7pTv/p/7v2JliHhUZgFGfjE0kuHI7d/VxFTRaSxTS/Ac9a4hE+vNqd4D2lTo8bSA p7ZORFelvjtEfVSRfEG89hB3JAlFB5YUNUk46w4ek7M3bdOxMXa/Ehlr8ob4Vp6vaZd+rN ElKCzFOMeFUsc3Dq4O03nPLXNwBABgNjtm9pzIXkd98Fszt0d4V0V5hZcya4dkcji3AQhh y/emqKSsFtgapGBzjnBcQSUBdTzgljbJBwkn3kEiseGu8+ZYcsZOqkWrmS5AOGSEzzMS1S gY/RGMflbSMXYFPMekv659/zfOI4Q2I4Ma1d/Uw1275s4dZMTKLYRB1bvCK1Pw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC56957F1C for ; Wed, 15 May 2024 20:00:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7Iv8-0002wD-6u; Wed, 15 May 2024 14:00:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7Iv4-0002vv-34 for guix-patches@gnu.org; Wed, 15 May 2024 14:00:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7Iv3-0006iW-OT for guix-patches@gnu.org; Wed, 15 May 2024 14:00:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7Iv4-0002Hs-Sr for guix-patches@gnu.org; Wed, 15 May 2024 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70892] [PATCH 4/6] gnu: Add u-boot-starfive-visionfive2. Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 May 2024 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70892 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zheng Junjie , 70892@debbugs.gnu.org Cc: Efraim Flashner Received: via spool by 70892-submit@debbugs.gnu.org id=B70892.17157959598738 (code B ref 70892); Wed, 15 May 2024 18:00:02 +0000 Received: (at 70892) by debbugs.gnu.org; 15 May 2024 17:59:19 +0000 Received: from localhost ([127.0.0.1]:43516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7IuN-0002Gs-G3 for submit@debbugs.gnu.org; Wed, 15 May 2024 13:59:19 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:44236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7IuL-0002Gl-8u for 70892@debbugs.gnu.org; Wed, 15 May 2024 13:59:17 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id BA6C01AA6D; Wed, 15 May 2024 10:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1715795944; bh=Gn02ypz7sVablEpl/f4VrUS/bfQic9DjewxUlSMR2q8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=V9/rA+/151tDaYd0z2rah8aPphQk6IqGIjBiQnnJuq4l1sbwbKlxL+DkvKMOsahjf GPMJD04rx0DrkZFQWXOWGTexk8YAsUapqSj5pmiXYEJJ3iH6jeU43JJSG6m3CkVW2Y a6sVcs3W2jwbbx76oKV5MlC2DG8KPYWeVR0E3FdTRVEUoFVMlMgYTHFDYrNHE6w26y dbjxcip93SD3aOTnMEclamliIRufq6TrGMJoclLajGUhZfY88wEEFzuCrARsE4pVz4 DA4U8+e17GmzBC95s8R/7IcAHvBb3gPGRVyn4yKm9aaKUZMSOTbuG3XSsR7AoAVVhy 1TY1TLGHffV5w== From: Vagrant Cascadian In-Reply-To: <7c3b72a45a1c5d6adfb6ccd586ab68d587cfc420.1715508730.git.zhengjunjie@iscas.ac.cn> References: <7c3b72a45a1c5d6adfb6ccd586ab68d587cfc420.1715508730.git.zhengjunjie@iscas.ac.cn> Date: Wed, 15 May 2024 10:59:01 -0700 Message-ID: <87o797rm6y.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.47 X-Spam-Score: -3.47 X-Migadu-Queue-Id: BC56957F1C X-Migadu-Scanner: mx13.migadu.com X-TUID: 32R0eQGOVKaS --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2024-05-12, Zheng Junjie wrote: > diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm > index cfe8046731..1d52e961fd 100644 > --- a/gnu/packages/bootloaders.scm > +++ b/gnu/packages/bootloaders.scm ... > @@ -1343,6 +1344,36 @@ (define-public u-boot-sifive-unmatched > (modify-inputs (package-inputs base) > (append opensbi-generic)))))) >=20=20 > +(define-public u-boot-starfive-visionfive2 > + (let ((opensbi (package > + (inherit opensbi-generic) > + (arguments > + (substitute-keyword-arguments > + (package-arguments opensbi-generic) > + ((#:make-flags flags) > + `(cons* "FW_TEXT_START=3D0x40000000" > + "FW_OPTIONS=3D0" > + ,flags)))))) > + (base (make-u-boot-package "starfive_visionfive2" "riscv64-linux= -gnu"))) I would not want to block this patch on this, but... Curious about the advantages and disadvantages of making this an on-the-fly opensbi package variant... as so far I think most u-boot packages just pull in inputs of other packages (e.g. arm-trusted-firmware-*) rather than modifying them as part of the u-boot-* package. If this seems to be a good approach overall, maybe we should switch more packages to use this approach ... or if there are significant downsides, perhaps this patch series should just create another opensbi variant and add it to inputs or whatever? Thoughts? That aside, looks good to me. :) Thanks! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZkT35QAKCRDcUY/If5cW qtT3AP4zp/3ZFL6JIkTI/yjjDG33Na9ttRZsCHJKcVQg2VlmTAD7BwEen64qZ3T8 amN+0POwur8Rgww0uz8FFvoExmWl7QQ= =eenE -----END PGP SIGNATURE----- --=-=-=--