From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id mEbOB2XOYGY6dAEAqHPOHw:P1 (envelope-from ) for ; Wed, 05 Jun 2024 22:45:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id mEbOB2XOYGY6dAEAqHPOHw (envelope-from ) for ; Wed, 05 Jun 2024 22:45:25 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b="r/D3TV5U"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717620325; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9gn4eosNEg6cuFQTzEqBx1l9wszMck/xtfJ8o4bS8oc=; b=Zn2v/vny0T/lC+qXtyr2nnZnOJPU4xxQhS5E2xitomBZEu5X+06d/Y0gzwxzUFKdDMOpn9 F4Myk1/35Onz9uZK9B2M9T3bamCmpBJyi9DIxk2XaJnSrOIuLBg8r6SnQZ3lY22R9wxerB CFOPOIjnH3SODjDyrP9qXSFPcKMkcKzP1qixQEeJXfgfz9i8WUUntk2lEhobT3B3eF4jLe Zj2lpA/eibvldFAo9PNDSpXG6A+wgIyZIFD3UIJKXBCmwqxkOAGsCsZ3Egd4wYbNOoXoyP iYM3elgL/PSo5FScQmXVcvSyJeB2iZ4iAW5nkvFxVtF3wUgq6Y8wtelHvgCIqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717620325; a=rsa-sha256; cv=none; b=Og6jd2tqTncHvU3VKy0e8489RgJhmnt2vfG+f3CiWlv86TzGxkyZ2NJUM+5yN4ciDk6Gqz anBHXcPhZhGcAvJeq2P+7viPIwicCBCPlWeCFvs1nD8Xgn3siQiZSxL6MewjIIrJsUVqCP WdPGrPX1w4k814oPaqgFfKGo4oroOOAtYSuoMENzTI9IbK+NchunUctFDcs1i+EDEtI78a 0hKGuxKIeAcG9JZmtRaMKVfRCh/7gHxAOylpDqjfCB7rQy1+jQMaSLesNn6qtdZzPUh6ux LN13WzfQ0l44pYOTqQdeaBQvDe5xzu4CB60qin9JnE82IYsZ3nb29TYuwE5VOg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b="r/D3TV5U"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C81FE617D7 for ; Wed, 05 Jun 2024 22:45:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sExV4-0003Fw-Er; Wed, 05 Jun 2024 16:44:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sExV3-0003Fa-6a for guix-patches@gnu.org; Wed, 05 Jun 2024 16:44:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sExV2-00049E-VK for guix-patches@gnu.org; Wed, 05 Jun 2024 16:44:48 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sExVG-0001Ca-QH for guix-patches@gnu.org; Wed, 05 Jun 2024 16:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71371] [PATCH] gnu: svn-fetch: Make revision field optional. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jun 2024 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71371 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 71371@debbugs.gnu.org, Josselin Poiret , Maxim Cournoyer , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Florian Pelz , Ricardo Wurmus , Christopher Baines , Matthew Trzcinski Received: via spool by 71371-submit@debbugs.gnu.org id=B71371.17176203024598 (code B ref 71371); Wed, 05 Jun 2024 20:45:02 +0000 Received: (at 71371) by debbugs.gnu.org; 5 Jun 2024 20:45:02 +0000 Received: from localhost ([127.0.0.1]:36353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sExVC-0001Bw-4J for submit@debbugs.gnu.org; Wed, 05 Jun 2024 16:45:01 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:53646 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sExV6-0001BS-Eg for 71371@debbugs.gnu.org; Wed, 05 Jun 2024 16:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1717620265; bh=jpLE5ELJtsvxnhpiJT6lBLRcmknVf73y1U8GvWM8/nU=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; b=r/D3TV5Ui7xy48uyYx/Mbgm2F/wHGOjANTds7h5zyJk+Z5qQN9oYPmCtR/wp98hWq yexdsS2G5Q7cl6zzwE3JjqmSUO/ta7L124y3WyHxUho+WUueUffbUdDWWS8Xid4OYC 2f7BNnVymai/M5tqLOStRr/nC5o09r62d6FrXjpU= Received: by b221-1.in.mailobj.net [192.168.90.21] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 5 Jun 2024 22:44:25 +0200 (CEST) X-EA-Auth: nWK8BDlu/yWc8OHKfPU30zNMKzG7M2zNPwxHkRIMYKVkkxNIJKB7ECwbJUsUbB68FEQN0xa1hElGdzqRg+M0wM/FAYy3Ospt8LrXUb1rX24= In-Reply-To: <874ja774nw.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 05 Jun 2024 18:09:07 +0200") References: <874ja774nw.fsf@gnu.org> Date: Wed, 05 Jun 2024 22:44:08 +0200 Message-ID: <87o78fw25j.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.84 X-Spam-Score: -0.84 X-Migadu-Queue-Id: C81FE617D7 X-Migadu-Scanner: mx11.migadu.com X-TUID: gQ5MQ7dD+8I7 Hello, Ludovic Court=C3=A8s writes: > Nicolas Goaziou skribis: > >> -@item @code{revision} >> -This string denotes revision to fetch specified as a number. >> +@item @code{revision} (default: @code{#f}) >> +This field denotes the revision to fetch, as a number. It can also be >> +set to @code{#f}, for example when @var{url} contains a tag reference. > > Hmm, IIRC, tags in svn are mutable, no? Disclaimer: prior to this patch, I knew nothing about SVN. So feel free to take my answers with a grain of salt. Now to answer your question, yes, they are mutable. But in practice, altering tagged contents seems to be frowned upon in the trunk-branch-tag trilogy. > My recollection is that there=E2=80=99s no distinction between a director= y, a > branch, and a tag: tags and branches are just a copy (=E2=80=98svn cp=E2= =80=99) of a > directory that can change over time. Thus, you can=E2=80=99t rely on a t= ag as > an unambiguous reference. > > Am I right? You are certainly right, but I think this patch still makes sense for projects that swear to never change tagged contents, which could possibly be the case for most of the projects using SVN. Every now and then, we will encounter a project that does modify such contents, but it also currently happens with tarballs: sometimes, upstream modifies the contents of a tarball without changing its name, inducing a hash mismatch. My concern here is that some Guix packages relying on `svn-fetch' provide both a tag and a revision, which is redundant. We could get rid of the tag, but the revision is not human-friendly. Regards, --=20 Nicolas Goaziou