From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id oPcIFJexZmYMQQEAe85BDQ:P1 (envelope-from ) for ; Mon, 10 Jun 2024 07:56:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id oPcIFJexZmYMQQEAe85BDQ (envelope-from ) for ; Mon, 10 Jun 2024 09:56:07 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718006167; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Kaups4h/ZpVMTrn4kTJU8P76r2qHusKQoisk1LTlBMs=; b=Vuuyvyf9kCV5+qMjCtj1vgUPC2pv+VzYbPRUd4ULVDmxv8rJcBifj/lNOrbRZvYmC0q5RB n8YxUhRCOis4/cIaovimf6Uj2AFgAUcp3OhsiO9SWwUKgodI93WF3Q6UWtHu10jmF5FRR/ 5iHVP/W1ts/XNUyizI2PtSDgLoCbqM5lCDGmr6nd+/vKGbFUeiJBLQpWh+etmFuy9lEFky NuUBLlnHmfW9o1d71IVIGwgvNluG4IBl55O9eA/MiqqQsWH9+4mv3zRtt43OO/OYRU9K/r SVOBF0sDHPWMbWxGWMkBgbWqLuyU4SONnRf9nnn4dZmKYZ7wwQxTmCY+NPQKAg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718006167; a=rsa-sha256; cv=none; b=W4zqBeD7nfPQN4564+T5B89aYyEYlyRldOSyBhZBso0YJ5Tx0CveW3Rb0z37oxhKArD0K/ LKn1Mfw+QSlstpmIF0WNea3nI4QGttA/L5sRG9dvYSqbQY3jhJxQY33lA5NbLiQP31N4Bz vtRVIjtiLv6uvDMaZkt8nC8YASBSi6h7iT4mvPgkZlGjl9IKcnHLJNcXwzn2nV1roQC0H8 eaNrH2BoxkT7FijF453nMnOMk0htuRQAbu4xGKH33ItQVm+k66LKwLC7kITvzUw8QD/JIo mpWeB8EIqV8qZ7/0gzEq0pMNaFZ2y4cO8MhD9PuccsDFsOTRqJRTqhAt1XZEYA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 17F4C7EC0C for ; Mon, 10 Jun 2024 09:56:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGZsa-0001hK-R9; Mon, 10 Jun 2024 03:55:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGZsY-0001gj-LL for guix-patches@gnu.org; Mon, 10 Jun 2024 03:55:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGZsY-0004pb-CZ for guix-patches@gnu.org; Mon, 10 Jun 2024 03:55:46 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGZso-0007G3-Fd for guix-patches@gnu.org; Mon, 10 Jun 2024 03:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71239] [PATCH] gnu: Add emacs-dape. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Jun 2024 07:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71239 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jlicht@fsfe.org, 71239@debbugs.gnu.org X-Debbugs-Original-To: Jelle Licht , Nicolas Graves via Guix-patches via , 71239@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171800613227794 (code B ref -1); Mon, 10 Jun 2024 07:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jun 2024 07:55:32 +0000 Received: from localhost ([127.0.0.1]:42646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGZsI-0007EA-N8 for submit@debbugs.gnu.org; Mon, 10 Jun 2024 03:55:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:59406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGZoG-00070x-Q1 for submit@debbugs.gnu.org; Mon, 10 Jun 2024 03:51:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGZnz-00007E-EI for guix-patches@gnu.org; Mon, 10 Jun 2024 03:51:03 -0400 Received: from 12.mo581.mail-out.ovh.net ([178.33.107.167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGZnw-0003vC-Jg for guix-patches@gnu.org; Mon, 10 Jun 2024 03:51:03 -0400 Received: from director6.ghost.mail-out.ovh.net (unknown [10.108.17.59]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id 4VyPB04cy1z1HTl for ; Mon, 10 Jun 2024 07:50:48 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-d6g8g (unknown [10.110.96.146]) by director6.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 1F7FF1FD4B; Mon, 10 Jun 2024 07:50:48 +0000 (UTC) Received: from ngraves.fr ([37.59.142.109]) by ghost-submission-6684bf9d7b-d6g8g with ESMTPSA id +Yf5AliwZmY0GgAAdzjNUA (envelope-from ); Mon, 10 Jun 2024 07:50:48 +0000 X-OVh-ClientIp: 90.110.172.34 In-Reply-To: <87r0d5et4f.fsf@fsfe.org> References: <20240528095800.20728-1-ngraves@ngraves.fr> <87r0d5et4f.fsf@fsfe.org> Date: Mon, 10 Jun 2024 09:50:28 +0200 Message-ID: <87o789tewr.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 12706906351449072368 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrfedtledgieekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeiueegteefleffheeiieetueffheffgefftdeukefhheetfeehleduhfejjedugfenucffohhmrghinhepshhrrdhhthdpghhnuhdrohhrghenucfkphepuddvjedrtddrtddruddpledtrdduuddtrddujedvrdefgedpfeejrdehledrudegvddruddtleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkedupdhmohguvgepshhmthhpohhuth Received-SPF: pass client-ip=178.33.107.167; envelope-from=ngraves@ngraves.fr; helo=12.mo581.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.04 X-Spam-Score: -4.04 X-Migadu-Queue-Id: 17F4C7EC0C X-Migadu-Scanner: mx11.migadu.com X-TUID: 5DjR6yBsN3fK On 2024-06-09 22:52, Jelle Licht wrote: > Hi Nicolas, > > I've got some nitpicks, and one question as the package does not seem to > run for me, which could very well be an issue on my end. > >> + (name "emacs-dape") >> + (version (git-version "0.12.0" revision commit)) > Is there a particular reason not to stick to the 'proper' releases? > If so, could you add a comment explaining why? There are no upstream tags, this is simply the commit of the tag, IIRC. So it's the proper release. Maybe I should simply put the version here and use git-version in the origin field instead ? >> + (arguments >> + ;; FIXME python tests pass, JS tests require additional dependencies >> + ;; See https://lists.sr.ht/~abcdw/rde-devel/patches/51878 >> + (list #:tests? #f > Can't we patch out or disable the JS tests, instead of not running any > tests? Doable, although using I'm not sure there's a light approach for this rather than patching half the file, which I think is not worth it. Will investigate. >> + #:test-command #~'("emacs" "--batch" "-l" "dape.el" >> + "-l" "dape-tests.el" >> + "-f" "ert-run-tests-batch-and-exit") >> + #:phases >> + #~(modify-phases %standard-phases >> + (add-after 'unpack 'support-unwrapped-python >> + (lambda _ >> + (substitute* "dape.el" >> + (("command \"python\"") >> + "command \"python3\"")))) > > I don't think we do this kind of patching for other packages, but I > could be mistaken of course. If this was needed to get the python tests > to succeed, maybe it could also work with python-minimal-wrapper instead > of patching. Since python is not propagated, this would mean that we expect the user to have python-wrapper instead of python, I'm not sure we want to enforce that because it might cause users to have to debug this. We can of course propagate python-wrapper instead, but then we increase the closure size. >> + (format #t "test suite not run~%"))))))) >> + (native-inputs (list node-lts python-minimal python-debugpy)) >> + (propagated-inputs (list emacs-jsonrpc)) > > Did running this package once installed actually work on your local > setup? If so, I'd love to know how you are running this package, as I'm > running into the issue as the one I reported at > https://issues.guix.gnu.org/71065 No, actually I couldn't, but I didn't settled for a stable configuration, I wanted to send that to RDE, but haven't done it yet. > Thanks for the package, > - Jelle -- Best regards, Nicolas Graves