From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: 73583@debbugs.gnu.org
Cc: csantosb@inventati.org
Subject: [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b.
Date: Tue, 15 Oct 2024 08:41:37 +0200 [thread overview]
Message-ID: <87o73lzx3y.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <5dc12ccaa4defdcbde87377ff165f2ce87a0a8f5.1727803250.git.csantosb@inventati.org> (Cayetano Santos via Guix-patches via's message of "Tue, 1 Oct 2024 19:20:50 +0200")
Hello,
Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-org-ref): Update to 3.1-0.732a20b.
Thank you. Some comments follow.
> #:exclude #~(list
> - ;; github.com/jkitchin/org-ref/issues/1085
> - "openalex.el"
Why are you removing these lines? There is no mention about it in your
commit message.
> ;; author doesn't recommend using it
> "org-ref-pdf.el")))
> (propagated-inputs
> - (list emacs-avy
> - emacs-citeproc-el
> - emacs-dash
> - emacs-f
> - emacs-helm
> - emacs-helm-bibtex
> - emacs-htmlize
> - emacs-hydra
> - emacs-ivy
> - emacs-ox-pandoc
> - emacs-parsebib
> - emacs-s))
> + (list
> + emacs-dash
> + emacs-s
> + emacs-f
> + emacs-htmlize
> + emacs-hydra
> + emacs-avy
> + emacs-parsebib
> + emacs-helm-bibtex
> + emacs-citeproc-el
> + emacs-ox-pandoc
> + emacs-request))
I don't understand the purpose of this change either. You're breaking
alphabetic order and use a dubious indentation.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2024-10-15 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 17:20 [bug#73583] [PATCH] gnu: emacs-org-ref: Update to 3.1-0.732a20b Cayetano Santos via Guix-patches via
2024-10-15 6:41 ` Nicolas Goaziou via Guix-patches via [this message]
2024-10-15 8:16 ` Cayetano Santos via Guix-patches via
2024-10-15 8:10 ` [bug#73583] [PATCH v1] " Cayetano Santos via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o73lzx3y.fsf@nicolasgoaziou.fr \
--to=guix-patches@gnu.org \
--cc=73583@debbugs.gnu.org \
--cc=csantosb@inventati.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).