From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id z11XM1vAEmeKCwAAqHPOHw:P1 (envelope-from ) for ; Fri, 18 Oct 2024 20:09:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id z11XM1vAEmeKCwAAqHPOHw (envelope-from ) for ; Fri, 18 Oct 2024 22:08:59 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=WkLN79Xh; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=dUuJQQYc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729282139; a=rsa-sha256; cv=none; b=IxpJMA4o4DVW4SxcCdQFzTc90He0kOoY8UZZp4yznCdzBopf5ADisSYOkgK+F6pq7bSe40 GSazcaISk6fs9sou45OFRCtDA2ra+kVCEw77q5PQuMCRNaVwErgy0iGM4aYwpofLhOjRzQ SSa40CwKSGIqPzYy8U2xXz7qvHxX5zvAPIGJflTCXqiafQYQIUno20TdI7ASvuebQPLsLQ cuU0Vkgt9AL4JR/JUFlHr8SFEWrY51euyXzwPugUoQRbtXoh49h9h28oD5HQtNeiBbDpb1 3SusIs4tvd6HPLd91DxG1ex8yzJ09t9HR08S43ylySn8Xn+pfo0Gk4+aR01Y/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=WkLN79Xh; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=dUuJQQYc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729282139; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pXQrLHVrGLUVxb/U2yFuMt/41k9BhcjrhkgqN/+rtcg=; b=TVelTHOnZ3zS3jjdA9SN/tHSOJhrIgVQ0RiBE+BFnHnLWd6OWwPo6N9jQD026Nlayqa8rO w8rtzma47+w1+8WTsVypVsGGNnYRAxb7hbsB4braQvVWd04kRdFlSJFvdn4ZSqb684cutX ciqxqQTU6/kcNjTNE4BYdzgH2NEzz9ob3ZUq2Q8UQPR1UNjFKcjf/cVji3f/utUWm54ylA k//ZS0MiUL7yzlCvBFLeyVKiXrMwB5bCPFsDlNsB87nOfBLvjem55i0z/jo50L6MNIacEG IBLlsiEP+5BWx00u2GKnSqf5YgbLe2tnAkEH/uP9fBivTvoFicFJWeeHeHtvgw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8F3AD738B3 for ; Fri, 18 Oct 2024 22:08:59 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1tH8-0006ut-19; Fri, 18 Oct 2024 16:08:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1tH6-0006uH-5j for guix-patches@gnu.org; Fri, 18 Oct 2024 16:08:40 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1tH5-0006vx-Tb for guix-patches@gnu.org; Fri, 18 Oct 2024 16:08:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=pXQrLHVrGLUVxb/U2yFuMt/41k9BhcjrhkgqN/+rtcg=; b=WkLN79XhhvV/UnS6Lv5Zzgc9yrmAwUWWZM3BpFQYZqgZAFUCX5nl9ELBCnCCbeMd/sy1ngWPiEM6TCJRc0SxF809VU/WZXrOtS485OU8u6jS8Wo8eXL4M8VTynK6BZVcZ2CL9/3pxJov2a8TZPHcOiO7yIwye2TSw+k3mkKaj6ANIuhUmkApJaCg2oUkEqDkQPrh0NhTzDDLtFnelz1eOEmav/V0nWGI2uIugnme9vFoZID2WuNK5Qf+RdMEFbTN8WLasp3Gi3E4kwWjvTbwgnezWzYdQBze0NNAkS2bVm3KExsdKWYhuXI2scEJYZcUprNYtZdFrb7VnFicaXx9yA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1tHS-0001jr-Jj for guix-patches@gnu.org; Fri, 18 Oct 2024 16:09:02 -0400 Subject: bug#72398: [PATCH] services: Add readymedia-service-type. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 18 Oct 2024 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72398 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fabio Natali Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Bruno Victal , 72398-done@debbugs.gnu.org Mail-Followup-To: 72398@debbugs.gnu.org, arunisaac@systemreboot.net, me@fabionatali.com Received: via spool by 72398-done@debbugs.gnu.org id=D72398.17292821396668 (code D ref 72398); Fri, 18 Oct 2024 20:09:02 +0000 Received: (at 72398-done) by debbugs.gnu.org; 18 Oct 2024 20:08:59 +0000 Received: from localhost ([127.0.0.1]:40176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1tHO-0001jU-Re for submit@debbugs.gnu.org; Fri, 18 Oct 2024 16:08:59 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:36328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1tHN-0001jI-3c for 72398-done@debbugs.gnu.org; Fri, 18 Oct 2024 16:08:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pXQrLHVrGLUVxb/U2yFuMt/41k9BhcjrhkgqN/+rtcg=; b=dUuJQQYcA8AFUlzqi4gXPN+dVB PjxrDSjta+hBNF7nFtY0etnStIffUWxZgoZNtCC872t+XFUvIEbqRUQnDYoVDqORNS8HYzxYsoy01 47g/RQz0cJlob4nQfvWz9uSosCwyXPkb6KwYrsPiop8AzADS8XNA7AO4tVZ12coGDJVlBt39lucbD 7BT/VSeKnzZecx6+vy7PwpLCIJBaE9WPWEonwaVFydDBsR8I5FCDwe+EwnA2/xJwgRqji6pZUu49L buKn2CKErrjDe4+x30RVJUKim9wq66DG2hB6nnxNrmka3vHmvtkT73NDSoie8iTDKTLToH0LuVtPX jmPGynNQ==; Received: from [192.168.2.1] (port=58144 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1t1tB2-000000007EL-2FVI; Fri, 18 Oct 2024 21:02:25 +0100 From: Arun Isaac In-Reply-To: <87ed4duwq0.fsf@fabionatali.com> References: <875xpqp5r7.fsf@systemreboot.net> <87ed4duwq0.fsf@fabionatali.com> Date: Fri, 18 Oct 2024 21:08:25 +0100 Message-ID: <87o73hnphi.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.87 X-Spam-Score: -0.87 X-Migadu-Queue-Id: 8F3AD738B3 X-Migadu-Scanner: mx10.migadu.com X-TUID: HnzuEHhrMTa6 Hi Fabio, Thanks for looking through all the changes. I appreciate that very much! :-) I have pushed the patch now. > Perhaps the only change I'd do at this point is around one or two > overflowing lines, personally I'd truncate them down to fit the 80-char > limit. Not a big deal and I'm also happy with v8 as it is. I fixed one of the overflowing lines, but there's still one sticking out slightly. I reckon it's ok, and it's more important that function arguments line up correctly. (list foo bar) instead of (list foo bar) > Given all the help given, have you considered adding your name to the > file header? Ah, no worries! This is quite a standard review, really. Regards, Arun