From: Grigory Shepelev <shegeley@gmail.com>
To: 73839@patchwise.org, sharlatanus@gmail.com
Subject: [bug#73839] comment on the new patchest
Date: Tue, 22 Oct 2024 12:02:13 +0300 [thread overview]
Message-ID: <87o73c7boq.fsf@gmail.com> (raw)
In-Reply-To: <20241016120244.12778-1-shegeley@gmail.com>
Execuse me. I wanted to add comment in every patch on what's changed,
but failed because I'm new with git+email workflow. Had to add this message.
Mostly the fixes are as you've mentioned
1. Move hash out of upper let
2. Move test inputs to native-inputs
3. Fix/add description where it's relevant
4. `search-inputs` -> `this-package-inputs/native-inputs` where possible
5. guix style all of them
Coundn't figure out cl transformations for cl-pango (sbcl-package->[cl/ecl]-source-package
sbcl-cl-pango) will fail with "error: sbcl-xmls: unbound
variable". Seems like there is no cl transformations for sbcl-xmls which
is an input.
This message and patches were sent to patchwise.org, not guix debuggs cos
access to the guix domain are unstable in my country. I hope it's not a problem.
--
Best regards,
Grigory Shepelev
prev parent reply other threads:[~2024-10-22 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 12:02 [bug#73839] [PATCH 1/5] lisp-xyz: + sbcl-posix-shm Grigory Shepelev
2024-10-16 12:41 ` [bug#73839] Clarification Grigory Shepelev
2024-10-18 8:31 ` [bug#73839] [PATCH 1/5] lisp-xyz: + sbcl-posix-shm Sharlatan Hellseher
2024-10-22 8:51 ` Grigory Shepelev
2024-10-22 8:51 ` [bug#73839] [PATCH 2/5] lisp-xyz: + sbcl-xkb (from @malcolmstill) Grigory Shepelev
2024-10-22 8:51 ` [bug#73839] [PATCH 3/5] lisp-xyz: + sbcl-cl-pango Grigory Shepelev
2024-10-22 8:51 ` [bug#73839] [PATCH 4/5] lisp-xyz: + sbcl-input-event-codes Grigory Shepelev
2024-10-22 8:51 ` [bug#73839] [PATCH 5/5] lisp-xyz: + sbcl-wayflan Grigory Shepelev
2024-10-22 9:02 ` Grigory Shepelev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o73c7boq.fsf@gmail.com \
--to=shegeley@gmail.com \
--cc=73839@patchwise.org \
--cc=sharlatanus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).