unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#39674] [PATCH] enable PostScript backend in Evince
@ 2020-02-19 12:08 raingloom
  2020-02-19 12:27 ` Nicolò Balzarotti
  2022-04-22 13:04 ` calcium via Guix-patches via
  0 siblings, 2 replies; 7+ messages in thread
From: raingloom @ 2020-02-19 12:08 UTC (permalink / raw)
  To: 39674

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

Some of my teacheres distribute notes in .ps files, so I kinda need 
this, and I think others will find it helpful as well.

AFAIK other distros enable it too.

Much easier than converting PostScript files to PDF.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-evince-enable-ps.patch --]
[-- Type: text/x-patch, Size: 974 bytes --]

From c767aa2d6a3d779d90e8185e313892eb2212dd37 Mon Sep 17 00:00:00 2001
From: raingloom <raingloom@protonmail.com>
Date: Wed, 19 Feb 2020 12:47:42 +0100
Subject: [PATCH] gnu: evince: --enable-ps

---
 gnu/packages/gnome.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3c63ab283d..5fae5d11ad 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1502,7 +1502,8 @@ forgotten when the session ends.")
                "05q6v9lssd21623mnj2p49clj9v9csw9kay7n4nklki025grbh1w"))))
     (build-system glib-or-gtk-build-system)
     (arguments
-     `(#:configure-flags '("--disable-nautilus" "--enable-introspection")
+     `(#:configure-flags '("--disable-nautilus" "--enable-introspection"
+                           "--enable-ps")
        #:phases
        (modify-phases %standard-phases
          (add-before 'install 'skip-gtk-update-icon-cache
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#39674] [PATCH] enable PostScript backend in Evince
  2020-02-19 12:08 [bug#39674] [PATCH] enable PostScript backend in Evince raingloom
@ 2020-02-19 12:27 ` Nicolò Balzarotti
  2020-02-20  7:05   ` Nicolò Balzarotti
  2020-03-18 10:02   ` Ludovic Courtès
  2022-04-22 13:04 ` calcium via Guix-patches via
  1 sibling, 2 replies; 7+ messages in thread
From: Nicolò Balzarotti @ 2020-02-19 12:27 UTC (permalink / raw)
  To: raingloom, 39674

Thanks!

I was wondering why it could not open .eps files!  I tested the patch,
applies, build and now I can open them.  guix size reports +3%
(1009.6 -> 1038.0).

+1 for merging

raingloom <raingloom@riseup.net> writes:

> Some of my teacheres distribute notes in .ps files, so I kinda need 
> this, and I think others will find it helpful as well.
>
> AFAIK other distros enable it too.
>
> Much easier than converting PostScript files to PDF.
>
> From c767aa2d6a3d779d90e8185e313892eb2212dd37 Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom@protonmail.com>
> Date: Wed, 19 Feb 2020 12:47:42 +0100
> Subject: [PATCH] gnu: evince: --enable-ps
>
> ---
>  gnu/packages/gnome.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 3c63ab283d..5fae5d11ad 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1502,7 +1502,8 @@ forgotten when the session ends.")
>                 "05q6v9lssd21623mnj2p49clj9v9csw9kay7n4nklki025grbh1w"))))
>      (build-system glib-or-gtk-build-system)
>      (arguments
> -     `(#:configure-flags '("--disable-nautilus" "--enable-introspection")
> +     `(#:configure-flags '("--disable-nautilus" "--enable-introspection"
> +                           "--enable-ps")
>         #:phases
>         (modify-phases %standard-phases
>           (add-before 'install 'skip-gtk-update-icon-cache
> -- 
> 2.25.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#39674] [PATCH] enable PostScript backend in Evince
  2020-02-19 12:27 ` Nicolò Balzarotti
@ 2020-02-20  7:05   ` Nicolò Balzarotti
  2020-02-22 23:24     ` raingloom
  2020-03-18 10:02   ` Ludovic Courtès
  1 sibling, 1 reply; 7+ messages in thread
From: Nicolò Balzarotti @ 2020-02-20  7:05 UTC (permalink / raw)
  To: raingloom, 39674

Should we enable DVI too? What are other distributions doing?

Nicolò Balzarotti <anothersms@gmail.com> writes:

> Thanks!
>
> I was wondering why it could not open .eps files!  I tested the patch,
> applies, build and now I can open them.  guix size reports +3%
> (1009.6 -> 1038.0).
>
> +1 for merging
>
> raingloom <raingloom@riseup.net> writes:
>
>> Some of my teacheres distribute notes in .ps files, so I kinda need 
>> this, and I think others will find it helpful as well.
>>
>> AFAIK other distros enable it too.
>>
>> Much easier than converting PostScript files to PDF.
>>
>> From c767aa2d6a3d779d90e8185e313892eb2212dd37 Mon Sep 17 00:00:00 2001
>> From: raingloom <raingloom@protonmail.com>
>> Date: Wed, 19 Feb 2020 12:47:42 +0100
>> Subject: [PATCH] gnu: evince: --enable-ps
>>
>> ---
>>  gnu/packages/gnome.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 3c63ab283d..5fae5d11ad 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -1502,7 +1502,8 @@ forgotten when the session ends.")
>>                 "05q6v9lssd21623mnj2p49clj9v9csw9kay7n4nklki025grbh1w"))))
>>      (build-system glib-or-gtk-build-system)
>>      (arguments
>> -     `(#:configure-flags '("--disable-nautilus" "--enable-introspection")
>> +     `(#:configure-flags '("--disable-nautilus" "--enable-introspection"
>> +                           "--enable-ps")
>>         #:phases
>>         (modify-phases %standard-phases
>>           (add-before 'install 'skip-gtk-update-icon-cache
>> -- 
>> 2.25.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#39674] [PATCH] enable PostScript backend in Evince
  2020-02-20  7:05   ` Nicolò Balzarotti
@ 2020-02-22 23:24     ` raingloom
  0 siblings, 0 replies; 7+ messages in thread
From: raingloom @ 2020-02-22 23:24 UTC (permalink / raw)
  To: 39674

Looks like it's an optional feature in Arch, provided by installing the 
texlive optional dependency.
Isn't that enough on Guix as well? I have no DVI files on hand to test 
it.

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/evince&id=f1f028f091aa277ffac13388e01d2d0f2f396fab

On Thu, Feb 20, 2020 at 08:05, Nicolò Balzarotti 
<anothersms@gmail.com> wrote:
> Should we enable DVI too? What are other distributions doing?
> 
> Nicolò Balzarotti <anothersms@gmail.com> writes:
> 
>>  Thanks!
>> 
>>  I was wondering why it could not open .eps files!  I tested the 
>> patch,
>>  applies, build and now I can open them.  guix size reports +3%
>>  (1009.6 -> 1038.0).
>> 
>>  +1 for merging
>> 
>>  raingloom <raingloom@riseup.net> writes:
>> 
>>>  Some of my teacheres distribute notes in .ps files, so I kinda need
>>>  this, and I think others will find it helpful as well.
>>> 
>>>  AFAIK other distros enable it too.
>>> 
>>>  Much easier than converting PostScript files to PDF.
>>> 
>>>  From c767aa2d6a3d779d90e8185e313892eb2212dd37 Mon Sep 17 00:00:00 
>>> 2001
>>>  From: raingloom <raingloom@protonmail.com>
>>>  Date: Wed, 19 Feb 2020 12:47:42 +0100
>>>  Subject: [PATCH] gnu: evince: --enable-ps
>>> 
>>>  ---
>>>   gnu/packages/gnome.scm | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>> 
>>>  diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>>>  index 3c63ab283d..5fae5d11ad 100644
>>>  --- a/gnu/packages/gnome.scm
>>>  +++ b/gnu/packages/gnome.scm
>>>  @@ -1502,7 +1502,8 @@ forgotten when the session ends.")
>>>                  
>>> "05q6v9lssd21623mnj2p49clj9v9csw9kay7n4nklki025grbh1w"))))
>>>       (build-system glib-or-gtk-build-system)
>>>       (arguments
>>>  -     `(#:configure-flags '("--disable-nautilus" 
>>> "--enable-introspection")
>>>  +     `(#:configure-flags '("--disable-nautilus" 
>>> "--enable-introspection"
>>>  +                           "--enable-ps")
>>>          #:phases
>>>          (modify-phases %standard-phases
>>>            (add-before 'install 'skip-gtk-update-icon-cache
>>>  --
>>>  2.25.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#39674] [PATCH] enable PostScript backend in Evince
  2020-02-19 12:27 ` Nicolò Balzarotti
  2020-02-20  7:05   ` Nicolò Balzarotti
@ 2020-03-18 10:02   ` Ludovic Courtès
  2024-10-22 14:17     ` Maxim Cournoyer
  1 sibling, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2020-03-18 10:02 UTC (permalink / raw)
  To: Nicolò Balzarotti; +Cc: 39674, raingloom, guix-security

Hi Nicolò & raingloom!

(+ Cc: guix-security)

Nicolò Balzarotti <anothersms@gmail.com> skribis:

> Thanks!
>
> I was wondering why it could not open .eps files!  I tested the patch,
> applies, build and now I can open them.  guix size reports +3%
> (1009.6 -> 1038.0).
>
> +1 for merging

I think PostScript support is often disabled by default because of
security issues: PostScript is a very versatile language and Ghostscript
has had a series of problems due to its inability to “sandbox”
PostScript code.

A particularly important issue is thumbnail generation: you could find
yourself running PostScript code without explicitly opening a file.

FWIW, I resort to gv (or ps2pdf) when I need to open a PostScript that I
deem trustworthy.

Leo, Mark, WDYT?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#39674] [PATCH] enable PostScript backend in Evince
  2020-02-19 12:08 [bug#39674] [PATCH] enable PostScript backend in Evince raingloom
  2020-02-19 12:27 ` Nicolò Balzarotti
@ 2022-04-22 13:04 ` calcium via Guix-patches via
  1 sibling, 0 replies; 7+ messages in thread
From: calcium via Guix-patches via @ 2022-04-22 13:04 UTC (permalink / raw)
  To: 39674

+1 for merging, .ps files are common enough.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#39674] [PATCH] enable PostScript backend in Evince
  2020-03-18 10:02   ` Ludovic Courtès
@ 2024-10-22 14:17     ` Maxim Cournoyer
  0 siblings, 0 replies; 7+ messages in thread
From: Maxim Cournoyer @ 2024-10-22 14:17 UTC (permalink / raw)
  To: Ludovic Courtès
  Cc: guix-security, 39674, raingloom, Nicolò Balzarotti

Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Nicolò & raingloom!
>
> (+ Cc: guix-security)
>
> Nicolò Balzarotti <anothersms@gmail.com> skribis:
>
>> Thanks!
>>
>> I was wondering why it could not open .eps files!  I tested the patch,
>> applies, build and now I can open them.  guix size reports +3%
>> (1009.6 -> 1038.0).
>>
>> +1 for merging
>
> I think PostScript support is often disabled by default because of
> security issues: PostScript is a very versatile language and Ghostscript
> has had a series of problems due to its inability to “sandbox”
> PostScript code.
>
> A particularly important issue is thumbnail generation: you could find
> yourself running PostScript code without explicitly opening a file.
>
> FWIW, I resort to gv (or ps2pdf) when I need to open a PostScript that I
> deem trustworthy.

My opinion is that we should enable it.  It's advertised as a
supported format [0]; if there was a serious security issue upstream
would probably drop support for it, or at least hide it behind some
configuration warning, and not advertize it.

Debian, known for its security track record, also has it enabled [1].

[0]  https://help.gnome.org/users/evince/stable/formats.html.en
[1]  https://salsa.debian.org/gnome-team/evince/-/blob/debian/latest/debian/rules?ref_type=heads#L15

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-10-22 14:19 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-19 12:08 [bug#39674] [PATCH] enable PostScript backend in Evince raingloom
2020-02-19 12:27 ` Nicolò Balzarotti
2020-02-20  7:05   ` Nicolò Balzarotti
2020-02-22 23:24     ` raingloom
2020-03-18 10:02   ` Ludovic Courtès
2024-10-22 14:17     ` Maxim Cournoyer
2022-04-22 13:04 ` calcium via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).