unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: Rostislav Svoboda <rostislav.svoboda@gmail.com>
Cc: Liliana Marie Prikler <liliana.prikler@gmail.com>,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	74135@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>
Subject: [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition.
Date: Fri, 01 Nov 2024 15:28:14 +0100	[thread overview]
Message-ID: <87o72zkozl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <2205123045e70a7cfb11d78405f48586e77df80e.1730382156.git.Rostislav.Svoboda@gmail.com> (Rostislav Svoboda's message of "Thu, 31 Oct 2024 14:42:47 +0100")

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> gnu/packages/emacs-xyz.scm (emacs-popwin): No need to switch off tests during
> build and no native-inputs needed.

Thank you.

I disagree with the removal of "#:tests? #f". It is more meaningful than
simply omitting the keyword. It tells us that the package has tests, but
they are difficult or even impossible to run. Without the keyword, it
could as well mean: "I didn't bother to check if there are tests".
I have no opinion about the removal of native inputs.

I also think the change to version should go in the second patch.

Regards,
-- 
Nicolas Goaziou






  parent reply	other threads:[~2024-11-01 14:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 13:42 [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition Rostislav Svoboda
2024-10-31 13:42 ` [bug#74136] [PATCH 2/2] gnu: Update emacs-popwin to 1.0.2.-2.58adcd0 Rostislav Svoboda
2024-11-01 14:28 ` Nicolas Goaziou via Guix-patches via [this message]
2024-11-01 17:54   ` [bug#74135] [PATCH 1/2] gnu: Improve emacs-popwin definition Rostislav Svoboda
2024-11-01 17:58     ` Rostislav Svoboda
2024-11-01 18:19     ` Nicolas Goaziou via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o72zkozl.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=74135@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    --cc=rostislav.svoboda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).