unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Rostislav Svoboda <rostislav.svoboda@gmail.com>
Cc: 66545-done@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>,
	66550-done@debbugs.gnu.org
Subject: bug#66545: [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
Date: Tue, 12 Nov 2024 20:52:08 +0900	[thread overview]
Message-ID: <87o72k4ql3.fsf@gmail.com> (raw)
In-Reply-To: <CAEtmmewNtKbqd39mttDhYW3pYnNZhYF1CqWFzmFm_jbD-GERDQ@mail.gmail.com> (Rostislav Svoboda's message of "Sat, 14 Oct 2023 22:26:07 +0200")

Hi,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

>> The tests should not be byte compilation.  In fact, these files should be compiled by the build phase.
>
> I see now that the emacs-build-system 'byte compiles all Emacs Lisp
> files.' Then, I think the entire `(arguments ...)` can be elided. If
> this is correct, I am resending the patch (see attachment). If not,
> please direct me to some examples or explain in more detail how to
> byte-compile the *.el file during the build phase. Thank you.
>
> (FYI the code under #:test-command was from
> https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)

I've applied it.

Thank you!

-- 
Maxim




  reply	other threads:[~2024-11-12 11:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-14 17:47 [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow Rostislav Svoboda
2023-10-14 18:29 ` Liliana Marie Prikler
2023-10-14 20:26   ` Rostislav Svoboda
2024-11-12 11:52     ` Maxim Cournoyer [this message]
2024-11-12 14:12     ` [bug#66550] " Maxim Cournoyer
2024-11-12 14:12       ` Maxim Cournoyer
     [not found] ` <handler.66545.B.169730574415684.ack@debbugs.gnu.org>
2023-10-14 22:09   ` [bug#66545] Acknowledgement ([PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.) Rostislav Svoboda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o72k4ql3.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66545-done@debbugs.gnu.org \
    --cc=66550-done@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=liliana.prikler@gmail.com \
    --cc=rostislav.svoboda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).