[bug#66550] [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

[bug#66550] [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

[Rostislav Svoboda]

* gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-solarized): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5fd851b38..26ea9dd84b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11081,6 +11081,30 @@ (define-public emacs-color-theme-sanityinc-tomorrow
 extensive face definitions than the \"official\" Emacs variant.")
       (license license:gpl3+))))
 
+(define-public emacs-color-theme-sanityinc-solarized
+  (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")
+        (revision "0"))
+    (package
+      (name "emacs-color-theme-sanityinc-solarized")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/purcell/color-theme-sanityinc-solarized")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "10vfbl9dry03dw264w7b4grmzcv78x3p7r86bsyhyl74hwwvx1hp"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/purcell/color-theme-sanityinc-solarized")
+      (synopsis
+       "Emacs color themes based on Ethan Schoonover's 'solarized' theme")
+      (description
+       "An alternate Emacs color-theme version of Ethan Schoonover's \"Solarized\"
+theme pair.")
+      (license license:gpl3+))))
+
 (define-public emacs-solarized-theme
   (package
     (name "emacs-solarized-theme")

base-commit: 3d0cdf963820da665d71987c15cae6e503efc701
prerequisite-patch-id: 0d0169efa833e9dd39a2b5c7ff264f733f212e5b
-- 
2.41.0

[bug#66550] Acknowledgement ([PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.)

[Rostislav Svoboda]

Please consider reviewing the following two patches together:

[PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
https://issues.guix.gnu.org/issue/66545

[PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.
https://issues.guix.gnu.org/issue/66550

Le dim. 15 oct. 2023 à 00:05, GNU bug Tracking System
<help-debbugs@gnu.org> a écrit :
>
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> As you requested using X-Debbugs-CC, your message was also forwarded to
>   Andrew Tropin <andrew@trop.in>, Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>, Liliana Marie Prikler <liliana.prikler@gmail.com>
> (after having been given a bug report number, if it did not have one).
>
> Your message has been sent to the package maintainer(s):
>  guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 66550@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 66550: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66550
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems

[bug#66550] [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

[Cayetano Santos via Guix-patches via]

+  (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")

It could be great to include latest commits from 2024

+      (license license:gpl3+))))

I see no license whatsoever in upstream repository, is that correct ?

[bug#66550] [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

[Rostislav Svoboda]

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

Hello

> +  (let ((commit "b8f4a65bd53b97b56b93fff2fb14f71b2831aa6f")
>
> It could be great to include latest commits from 2024

Uff, that's been more than a year since I sent the patch!
Anyway, I updated it and also slightly tweaked the synopsis. See attachment.

> +      (license license:gpl3+))))
>
> I see no license whatsoever in upstream repository, is that correct ?

The color-theme-sanityinc-solarized repository does not include an
explicit license file. However, the main source file,
color-theme-sanityinc-solarized.el, contains the following header:

;; This program is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.

Cheers Bost

[-- Attachment #2: 0001-gnu-Add-emacs-color-theme-sanityinc-solarized.patch --]
[-- Type: text/x-patch, Size: 2002 bytes --]

From fb2d6a3541d425edd2b17eed1bb185752a0adadb Mon Sep 17 00:00:00 2001
Message-ID: <fb2d6a3541d425edd2b17eed1bb185752a0adadb.1730982465.git.Rostislav.Svoboda@gmail.com>
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Thu, 7 Nov 2024 13:24:37 +0100
Subject: [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

* gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-solarized): New variable.

Change-Id: Ic989e64cc532529772cda51e1f49b53d6aa4c073
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 88e1ab89a9..63b6a6da1a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11096,6 +11096,30 @@ (define-public emacs-slime
 for compilation, debugging, documentation lookup, and so on.")
     (license (list license:gpl2+ license:public-domain))))
 
+(define-public emacs-color-theme-sanityinc-solarized
+  (let ((commit "9c62a49fe0a5ff456bcf3984ba825e75861534b9")
+        (revision "0"))
+    (package
+      (name "emacs-color-theme-sanityinc-solarized")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url
+                "https://github.com/purcell/color-theme-sanityinc-solarized")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0vakjdm5xf7ahxf39j4bc38irkwyv8xkp45akqfc7z252vpxi44k"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/purcell/color-theme-sanityinc-solarized")
+      (synopsis "Solarized color themes for Emacs")
+      (description
+       "An alternate Emacs color-theme version of Ethan Schoonover's \"Solarized\"
+theme pair.")
+      (license license:gpl3+))))
+
 (define-public emacs-popup
   (package
     (name "emacs-popup")

base-commit: 2a6d96425eea57dc6dd48a2bec16743046e32e06
-- 
2.46.0

[bug#66550] [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

[Rostislav Svoboda]

Hello Cayetano,

It would be great if you could merge my patch. It’s not particularly
important - just a trivial piece of code - but it has been lingering
for quite some time now. Specifically, for 1 year and 1 month, minus 1
day ;-)

Cheers,
Bost

[bug#66550] [PATCH] gnu: Add emacs-color-theme-sanityinc-solarized.

[Cayetano Santos via Guix-patches via]

>jeu. 14 nov. 2024 at 12:56, Rostislav Svoboda <rostislav.svoboda@gmail.com> wrote:

> Hello Cayetano,
>
> It would be great if you could merge my patch. It’s not particularly
> important - just a trivial piece of code - but it has been lingering
> for quite some time now. Specifically, for 1 year and 1 month, minus 1
> day ;-)

I’m not a guix committer, I’m just reviewing patches, and yours was fine to me.

I think I understand the tweak here. You have ask to merge 66545
(solarized) and 66550 (tomorrow). The later was merged a couple of days
ago, so both are considered as done now.

https://issues.guix.gnu.org/66550
https://issues.guix.gnu.org/66545

If I’m right, you’ll better ask Maxim (the committer) to consider the
situation.

C.

[bug#66550] QA review for 66550

[Cayetano Santos via Guix-patches via]

user guix
usertag 66550 + reviewed-looks-good
thanks

Guix QA review form submission:


Items marked as checked:

- Commit messages
- Package builds
- Lint warnings
- Package tests
- Package style
- List dependent packages build

- New package licenses
- New package tests
- New package synopsis and descriptions