From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gEptLO0/RGfmdwAAqHPOHw:P1 (envelope-from ) for ; Mon, 25 Nov 2024 09:14:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id gEptLO0/RGfmdwAAqHPOHw (envelope-from ) for ; Mon, 25 Nov 2024 10:14:21 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=JSsJYlSj; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=ZKSk1VHV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732526061; a=rsa-sha256; cv=none; b=pg5siSnlbYyS3sV9ri3sHZEeb04Ca67CUMyBioi4luFFmgAIFtdWmin4+c5nQ0EosHTXZx nHsUsQQdB3nGJWegKX5Kd9oJ8NQxjqap4EHLT4nrsodos3MD+wqu/sJGP++IZjDZTaOhGv lYR/5bhOwcXqdRf1k2/6KLg7wqemdbhy41Ab3uumlcXK+c/lW4hSuZY7+1PI0EKquM/0tG +q7dNcV1xGHv48SavjgXKCWhzOWGGgPKDkom7ca6CAUDJRgddAPF1NyEw4jUmnwO7os5S1 d+PE2ue8MCoDmtjRW45GU2RgoLNN7SIFrezZYrQnIYpp4jBzwH4eYOhkWZpaUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=JSsJYlSj; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=ZKSk1VHV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732526061; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zSnJsaPWrFqVnfy6OoTl7bjLQZEe0gmbDtodmHb0IjU=; b=hpkp6ihCSI8UFbN5ofdUNCCHWr8cfXjtNRfh4wVuJVjkYgMgUPNutrY1yDlxZSph91VDKV u0tWqz9MAi6Tl05lW0U4+89paJstPQEhZhakeKFx42SLopK9chtQkM4mj6CjACNM690TQt A18R0ix770rF9PdYiLWUIPGQM/3YSZw6impzcSImu2SEQ98TylUqpOkzFRLRZbuIqFM/jR FVvNMwWYmwTgI4myjCJUjjwD2ouLR/sUsxc2CE8kAnFakGLBhn5y7Hlm6sk0VzhI9MF07v uxzuwuqA8ZxQidAHS8D7TcAjfpV3N+olnbWhA15kdZVTHjenME45w1NLYJYNjQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA59C5FFF for ; Mon, 25 Nov 2024 10:14:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFVAS-0007kj-Ao; Mon, 25 Nov 2024 04:14:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFVAQ-0007kY-CA for guix-patches@gnu.org; Mon, 25 Nov 2024 04:14:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tFVAQ-0000xT-3W for guix-patches@gnu.org; Mon, 25 Nov 2024 04:14:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=zSnJsaPWrFqVnfy6OoTl7bjLQZEe0gmbDtodmHb0IjU=; b=JSsJYlSjG3e52iYTOriG7VBkX1/iuCSx5FCooABz+HknhKrXKDPh4oxAlg0CCquk7WTIutcIjltONSqlsScJdFWEqzTjKNEqKze6VVilBiuwyUxgGX3XoVWX+hIErbvMhLi+tVq8NEkLqxGovfnkSi/HpTizlStEnzSOsN46/6Fvwu/kN3ULCEll45Y1aeJzgxgRKU79pcfRdwhNbe0TFAjUzlGHcymnvbhMBoQLVCY6oXLQF3qZarmtzCtwe+41yibLyumLwvhxFD+9z6o8/Jzoes1enShfBDsu+t2hY9TbvK17UAl7OyOCB3c8FMulIWzRR7VDvyrBpMmr/9xn9g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tFVAP-0004Za-UA for guix-patches@gnu.org; Mon, 25 Nov 2024 04:14:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74253] [PATCH] transformations: Add multituned-package. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Nov 2024 09:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Christopher Baines , 74253@debbugs.gnu.org Received: via spool by 74253-submit@debbugs.gnu.org id=B74253.173252602717545 (code B ref 74253); Mon, 25 Nov 2024 09:14:01 +0000 Received: (at 74253) by debbugs.gnu.org; 25 Nov 2024 09:13:47 +0000 Received: from localhost ([127.0.0.1]:37857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFVAB-0004Yt-9x for submit@debbugs.gnu.org; Mon, 25 Nov 2024 04:13:47 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:13839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFVA9-0004Yf-BH for 74253@debbugs.gnu.org; Mon, 25 Nov 2024 04:13:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=zSnJsaPWrFqVnfy6OoTl7bjLQZEe0gmbDtodmHb0IjU=; b=ZKSk1VHVft87Pnd/i1CT6PWtgPlYVD3tiiTIt8zo3NcZUBWBCz45wfcp 1qgydVZUrliVwJHJSiL5TYspR46f9iYx3PfuEQ1sJ7c4rM2/YPkbArsP8 HOS/7KIq81grJCh+t/vdhYgaAv91NnPM65LcITWsnRvngUs/uEtkhpbRS k=; X-IronPort-AV: E=Sophos;i="6.12,182,1728943200"; d="scan'208";a="102528313" Received: from unknown (HELO ribbon) ([193.50.110.122]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2024 10:13:39 +0100 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Efraim Flashner's message of "Sat, 23 Nov 2024 20:35:16 +0200") References: <87serwu4iq.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 5 Frimaire an 233 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Cochon X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 Nov 2024 10:13:38 +0100 Message-ID: <87o723fzgd.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.85 X-Spam-Score: -3.85 X-Migadu-Queue-Id: EA59C5FFF X-Migadu-Scanner: mx12.migadu.com X-TUID: /KHtTyORRBLQ Hello, Efraim Flashner skribis: > On Tue, Nov 12, 2024 at 11:31:57AM +0100, Ludovic Court=C3=A8s wrote: [...] >> Should that be a package transformation though? Could we instead have a >> build system trick or the =E2=80=98multituned-package=E2=80=99 procedure= exposed so >> build the package several times and fill in lib/glibc-hwcaps? > > I figured (guix transformations) worked well since it was using an > existing transformation to generate the different variants. > > I'm not sure what you mean by a build system trick, like build the > package multiple times in one like with x265? Yes, that sort of thing, or basically what you have here but provided as a build phase. Now, it=E2=80=99s probably easier to implement it the way you did than as a build phase, because how exactly to rebuild a package with the right optimizations is very dependent on details about its build system. > This exposes the multituned-package procedure (looks like I mistyped in > the commit message) which takes a package and can be just added on top > of an existing package definition, like hidden-package can. Yes, but I think the key ideal with hwcaps is that, contrary to what =E2=80=98--tune=E2=80=99 does, we=E2=80=99d provide several optimized versi= ons upfront. In that sense, we=E2=80=99d statically choose to =E2=80=9Cmulti-tune=E2=80=9D certa= in packages. >> That way, packagers would explicitly choose this technique for select >> packages, which would then no longer need the =E2=80=98tunable?=E2=80=99= property. > > Something like a flag in the build-system like #:tests? is? Or like a > package property? Either that, or write (define p' (multituned-package p)) etc. The key point being: packagers would be the one deciding that. So hmm, maybe the way forward is to keep the =E2=80=98multituned-package=E2= =80=99, but just not expose it as a package transformation. Also, we might want to move tuning support to (guix cpu-tuning) or similar, which is the module that packagers would import (rather than (guix transformations)). WDYT? Ludo=E2=80=99.