unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Runciter via Guix-patches via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 75063@debbugs.gnu.org
Subject: [bug#75063] [PATCH 1/2] gnu: dict: Add symbols to help users configure FreeDict with dicod.
Date: Sun, 29 Dec 2024 18:35:19 +0000	[thread overview]
Message-ID: <87o70u5odd.fsf@whispers-vpn.org> (raw)
In-Reply-To: <cover.1735043982.git.runciter@whispers-vpn.org>

Hello Ludo,

I tested your config in a VM and it's not as bad as I thought. There's a
little problem though, which is one of those I anticipated: the
`load-module` statement of dicod.conf is uselessly repeated for each
non-complex dictorg database configured by the Guix service.

I have copied the dicod.conf that your configuration creates at the
bottom of this message. You can see the duplicates statements, 4 in your
case because you configured 4 non-complex dictorg dictionaries.

I'm going to go for symbols which create non-complex databases, like
your config. It's probably not going to be very easy to see if the
duplicate module loading in dicod causes a performance hit when one uses
a large number of dictorg databases, or all of them... Therefore, in the
info manual, I'm also going to change the configuration example into one
where only a handful of databases are registered into the service, as
opposed to all of them in my initial patch.

I'll send a revised patch later this week.

If that is deemed to be required, in order to fix the duplicate module
loading of dicod, one could always change the Scheme in the
`dicod-configuration-file` procedure.

Runciter

== BELOW THE dicod.conf CREATED WITH 4 NON-COMPLEX DICTORG DATABASES: ==
listen (localhost);

load-module gcide;
database {
   name "gcide";
   handler "gcide dbdir=/gnu/store/wsxc3jg8m2fi7qhlr2rrv4ik9vqhv6bp-gcide-0.53/share/gcide idxdir=/gnu/store/jflf8h70g61fsc4xgclasghjsmwqsa5c-dicod-gcide-index";
}

load-module dictorg;
database {
   name "freedict";
   handler "dictorg database=/gnu/store/nld9vc9f9jgk3x4hawjlnnzw8vzvavz2-freedict-dictionaries-0.0.0-0.914b5f7/share/dictd/fra-eng";
}

load-module dictorg;
database {
   name "freedict";
   handler "dictorg database=/gnu/store/nld9vc9f9jgk3x4hawjlnnzw8vzvavz2-freedict-dictionaries-0.0.0-0.914b5f7/share/dictd/eng-fra";
}

load-module dictorg;
database {
   name "freedict";
   handler "dictorg database=/gnu/store/nld9vc9f9jgk3x4hawjlnnzw8vzvavz2-freedict-dictionaries-0.0.0-0.914b5f7/share/dictd/eng-spa";
}

load-module dictorg;
database {
   name "freedict";
   handler "dictorg database=/gnu/store/nld9vc9f9jgk3x4hawjlnnzw8vzvavz2-freedict-dictionaries-0.0.0-0.914b5f7/share/dictd/spa-eng";
}





  parent reply	other threads:[~2024-12-29 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-24 12:47 [bug#75063] [PATCH 0/2] Easy configuration of FreeDict into dicod-service-type Runciter via Guix-patches via
2024-12-24 13:00 ` [bug#75063] [PATCH 1/2] gnu: dict: Add symbols to help users configure FreeDict with dicod Runciter via Guix-patches via
2024-12-25 21:23   ` Ludovic Courtès
2024-12-24 13:00 ` [bug#75063] [PATCH 2/2] doc: add FreeDict dictionaries to dicod configuration example Runciter via Guix-patches via
2024-12-26 16:22 ` [bug#75063] [PATCH 1/2] gnu: dict: Add symbols to help users configure FreeDict with dicod Runciter via Guix-patches via
2024-12-29 18:35 ` Runciter via Guix-patches via [this message]
2025-01-01 19:23 ` [bug#75063] [PATCH v2] " Runciter via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o70u5odd.fsf@whispers-vpn.org \
    --to=guix-patches@gnu.org \
    --cc=75063@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=runciter@whispers-vpn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).