From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 74860@debbugs.gnu.org
Subject: [bug#74860] [PATCH 03/10] services: log-cleanup: Rewrite as a Shepherd timer.
Date: Thu, 02 Jan 2025 23:24:35 +0900 [thread overview]
Message-ID: <87o70p5m58.fsf@gmail.com> (raw)
In-Reply-To: <3a485dfad94faba0205b96f0b742bea6056512a7.1734129908.git.ludo@gnu.org> ("Ludovic Courtès"'s message of "Fri, 13 Dec 2024 23:58:23 +0100")
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> This is a semi-incompatible change: gexps previously provided in the
> ‘schedule’ field will no longer work.
>
> * gnu/services/admin.scm (log-cleanup-mcron-jobs): Remove.
> (log-cleanup-shepherd-services): New procedure.
> (log-cleanup-service-type): Extend SHEPHERD-ROOT-SERVICE-TYPE instead of
> MCRON-SERVICE-TYPE.
> * doc/guix.texi (Log Rotation): Adjust ‘schedule’ documentation
> accordingly.
[...]
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 89a85961ac..e7784404d6 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -20973,8 +20973,9 @@ Log Rotation
> default).
>
> @item @code{schedule} (default: @code{"30 12 01,08,15,22 * *"})
> -String or gexp denoting the corresponding mcron job schedule
> -(@pxref{Scheduled Job Execution}).
> +This is the schedule of the log cleanup job written either a string
> in
typo: either *as* a string
Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
--
Thanks,
Maxim
next prev parent reply other threads:[~2025-01-02 15:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 22:55 [bug#74860] [PATCH 00/10] Using the Shepherd's log rotation service Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 01/10] gnu: shepherd@1.0: Add dependency on gzip and zstd Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 02/10] services: Add ‘log-rotation-service-type’ Ludovic Courtès
2025-01-02 14:19 ` Maxim Cournoyer
2025-01-04 18:16 ` Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 03/10] services: log-cleanup: Rewrite as a Shepherd timer Ludovic Courtès
2025-01-02 14:24 ` Maxim Cournoyer [this message]
2024-12-13 22:58 ` [bug#74860] [PATCH 04/10] services: unattended-upgrade: " Ludovic Courtès
2025-01-02 14:28 ` Maxim Cournoyer
2024-12-13 22:58 ` [bug#74860] [PATCH 05/10] services: Switch from mcron + Rottlog to Shepherd’s log rotation Ludovic Courtès
2025-01-02 14:41 ` Maxim Cournoyer
2024-12-13 22:58 ` [bug#74860] [PATCH 06/10] services: rottlog: Deprecate Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 07/10] DRAFT news: Add entry for ‘rottlog-service-type’ deprecation Ludovic Courtès
2024-12-14 18:34 ` pelzflorian (Florian Pelz)
2024-12-17 14:25 ` Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 08/10] home: services: Add log rotation service Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 09/10] home: Define ‘%base-home-services’ Ludovic Courtès
2025-01-02 14:34 ` Maxim Cournoyer
2024-12-13 22:58 ` [bug#74860] [PATCH 10/10] home: Add log rotation to ‘%base-home-services’ Ludovic Courtès
2025-01-02 14:34 ` Maxim Cournoyer
2024-12-13 23:20 ` [bug#74860] [PATCH 00/10] Using the Shepherd's log rotation service Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o70p5m58.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=74860@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).