From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxZaz-0002Uw-79 for guix-patches@gnu.org; Mon, 10 Apr 2017 09:43:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxZaw-0005F3-5A for guix-patches@gnu.org; Mon, 10 Apr 2017 09:43:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cxZaw-0005Ey-1X for guix-patches@gnu.org; Mon, 10 Apr 2017 09:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cxZav-0008UM-Qy for guix-patches@gnu.org; Mon, 10 Apr 2017 09:43:01 -0400 Subject: bug#26341: [PATCH 1/5] build: syscalls: Add reboot. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170408160329.4068-1-m.othacehe@gmail.com> <20170408160329.4068-2-m.othacehe@gmail.com> <87lgr8fvk7.fsf@gnu.org> <8637dgs8nt.fsf@gmail.com> Date: Mon, 10 Apr 2017 15:41:51 +0200 In-Reply-To: <8637dgs8nt.fsf@gmail.com> (Mathieu Othacehe's message of "Mon, 10 Apr 2017 15:18:30 +0200") Message-ID: <87mvbobcrk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 26341@debbugs.gnu.org Hi, Mathieu Othacehe skribis: >> The problem is that we cannot #:replace unconditionally (when not using >> the patched Guile, there=E2=80=99s nothing to replace=C2=B9). > > Yes I was relying on #:replace ability to just export the symbol if > there's nothing to replace (as explained in your note=C2=B9). > >> >> WDYT? > > Anyway, your macro seems a nicer way than dealing with export/replace. > I gave it a try and everything still seems warning free. > > My only concern is that it won't be obvious for people who want to use > reboot or mount or any other syscall that they have to use (guix build > syscalls) because the #:export list won't contain those syscalls. > > Maybe a big explanation on top of the file would be enough ? Yes, I think it would be enough. Also, the initrd is the only context where one can omit (use-modules (guix build syscalls)) so I think people will choose to use it by default. Thanks, Ludo=E2=80=99.