From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d71nV-0004Ym-C3 for guix-patches@gnu.org; Sat, 06 May 2017 11:39:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d71nS-00050S-A9 for guix-patches@gnu.org; Sat, 06 May 2017 11:39:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d71nS-00050G-6K for guix-patches@gnu.org; Sat, 06 May 2017 11:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d71nR-0002UJ-Ta for guix-patches@gnu.org; Sat, 06 May 2017 11:39:01 -0400 Subject: bug#26730: [PATCH] Fix bzip2 utilities Resent-Message-ID: From: Marius Bakke In-Reply-To: References: Date: Sat, 06 May 2017 17:38:45 +0200 Message-ID: <87mvaqyoze.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines , 26730@debbugs.gnu.org --=-=-= Content-Type: text/plain Christopher Baines writes: > The bzip2 package includes wrappers around diff, grep and less/more. > These shell scripts currently include /usr/bin (and sometimes /bin) on > the PATH, and therefore fail if any of the commands that they rely on > cannot be found. > > By substituting /usr/bin (and /bin) for the appropriate package paths, > these scripts work much more reliably. Most of these dependencies are available in environments where the bz* tools will be executed. I think it would be better to simply remove the absolute /usr/bin and /bin references such that grep, sed etc invocations are picked up from PATH instead. The "xz*" equivalent tools seem to do that. The rationale being that bzip2 is often needed early in bootstrapping, and adding those inputs would complicate the dependency tree. Although I admittedly haven't looked at how bzip2 is used in Guix bootstrap. Thoughts? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkN7gUACgkQoqBt8qM6 VPqMmwgAr+2rlrBWze3dWudqZkIEVgwRgmrj2pu9/Q8Kryd+GrmZuEbK9Kzzp4Ac I3Oowd+fDgr2m0Pa9vr7sHPLZtxZE7g9WC+uzGI6vDSOAdn7v96BV1Q9qkbDN03C Vlm82Cl8dIMGoXYUuNur6QU7C8RFnO/riGaPOOtRoLVqsNfqxEIcFwPUMeg/TmmF bdkkvH+yTJozdRqKZE2bFhj11QJZBhSCwBPbj/Y2NoBw6RPvT36PmVNrfD2Xv1EX W1hY3fSB87uzypyWblXylOscvlvygrITx41iBfeMQU6sPNHPd1d4bsYFH06DraTG w8C9G56vnLeqpo9UW+E2Txj9SpAaXw== =rQv+ -----END PGP SIGNATURE----- --=-=-=--