From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8SZ5-0007Fv-5H
	for guix-patches@gnu.org; Wed, 10 May 2017 10:26:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8SZ0-0008SJ-TM
	for guix-patches@gnu.org; Wed, 10 May 2017 10:26:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34176)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d8SZ0-0008SD-Jp
	for guix-patches@gnu.org; Wed, 10 May 2017 10:26:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8SZ0-00030h-FF
	for guix-patches@gnu.org; Wed, 10 May 2017 10:26:02 -0400
Subject: bug#26803: [PATCH 19/36] gnu: Add java-commons-codec.
Resent-Message-ID: <handler.26803.B26803.149442636111568@debbugs.gnu.org>
References: <20170506153617.3074-1-rekado@elephly.net>
	<20170506153617.3074-19-rekado@elephly.net> <rbulgq5qb0q.fsf@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <rbulgq5qb0q.fsf@gnu.org>
Date: Wed, 10 May 2017 16:25:52 +0200
Message-ID: <87mvakhjpr.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: Hartmut Goebel <h.goebel@crazy-compilers.com>, 26803@debbugs.gnu.org


Roel Janssen <roel@gnu.org> writes:

> Ricardo Wurmus writes:
>
>> From: Hartmut Goebel <h.goebel@crazy-compilers.com>
>>
>> * gnu/packages/java.scm (java-commons-codec): New variable.
>>
>> Co-authored-by: Ricardo Wurmus <rekado@elephly.net>
>> ---
[…]
>> +    (arguments
>> +     `(#:test-target "test"
>> +       #:make-flags
>> +       (let ((hamcrest (assoc-ref %build-inputs "java-hamcrest-core"))
>> +             (junit    (assoc-ref %build-inputs "java-junit")))
>> +         (list (string-append "-Djunit.jar=" junit "/share/java/junit.jar")
>> +               (string-append "-Dhamcrest.jar=" hamcrest
>> +                              "/share/java/hamcrest-core.jar")
>> +               ;; Do not append version to jar.
>> +               "-Dfinal.name=commons-codec"))
>> +       #:phases
>> +       ;; TODO: I don't like this
>> +       (modify-phases %standard-phases
>> +         (add-after 'build 'build-javadoc
>> +           ant-build-javadoc)
>> +         (replace 'install
>> +           (install-jars "dist"))
>> +         ;; TODO: do this if javadoc argument is given?
>> +         (add-after 'install 'install-doc
>> +           (install-javadoc "dist/docs/api")))))
>
> Is this a good moment to look into these TODOs?  I don't think they are
> that bad, and the output includes the Javadoc stuff, right?

Yeah, I think I don’t feel so strongly about this any more.  I’ve
removed the TODOs.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net