From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deq9A-0003oS-9B for guix-patches@gnu.org; Mon, 07 Aug 2017 18:05:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deq90-0003VI-BA for guix-patches@gnu.org; Mon, 07 Aug 2017 18:05:12 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1deq90-0003V4-5V for guix-patches@gnu.org; Mon, 07 Aug 2017 18:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1deq8z-0003To-RD for guix-patches@gnu.org; Mon, 07 Aug 2017 18:05:01 -0400 Subject: [bug#27971] [PATCH] gnu: Add ois. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170805170820.4766-1-manolis837@gmail.com> References: <20170805170820.4766-1-manolis837@gmail.com> Date: Tue, 08 Aug 2017 00:04:15 +0200 Message-ID: <87mv7bavc0.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: manolis837@gmail.com, 27971@debbugs.gnu.org --=-=-= Content-Type: text/plain manolis837@gmail.com writes: > From: Manolis Ragkousis > > * gnu/packages/game-development.scm (ois): New variable. [...] > +(define-public ois > + (package > + (name "ois") > + (version "1.3") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "git://github.com/wgois/OIS.git") > + (commit "bb75ccc1aabc1c547195579963601ff6080ca2f2"))) Can you add a note about why we need a git checkout? Also, please use HTTPS here. > + (file-name (string-append name "-" version)) > + (sha256 > + (base32 > + "0w0pamjc3vj0jr718hysrw8x076fq6n9rd6wcb36sn2jd0lqvi98")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-before 'configure 'bootstrap > + (lambda _ (zero? (system* "sh" "bootstrap"))))))) This should be done after 'unpack' to not compete against the various 'patch-shebang' phases. > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) > + ("m4" ,m4) > + ("pkg-config" ,pkg-config))) > + (inputs > + `(("libxaw" ,libxaw))) > + (synopsis "Object Oriented Input System") > + (description > + "Cross Platform Object Oriented Input Lib System. Meant to be very robust > +and compatiable with many systems and operating systems.") ^^^ typo Feel free to expand on the description if you can, but LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmI498ACgkQoqBt8qM6 VPrQtwf/Y5jwDSvuo1boMtEs9TtQbK+76Xm9l/wzlZ8z8yolha7bOp2XJtf+idDI mc3EUYMSnt0bx7bD6/7uquXMc4n29dopI5XItKfIrzWGkbl/GDjETsmRD/Dixx2n FUCRQtYXtNSja17eilko2cI3ysODfbSZFeRvD5h4KMaW+QV/z0fC/MJRCBDAHHjA 846fs0OEqlTpUrBRhPkk6xnCqwdRc1Rd0/KIANP9i6UTVPUjAqpBCHseWLCTta13 GjKi3i3YCL0msiA/ZtutLi5ZlnVjvQLQgyEBVVNUNaSFC+4FAZwf45td/23RRGwU /UMnqZg6kde10EEelEsUqE6E4rgPCA== =pUDR -----END PGP SIGNATURE----- --=-=-=--