unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: ng0 <ng0@infotropique.org>, 28253-done@debbugs.gnu.org
Subject: bug#28253: perl-www-opensearch: provide Test-Simple module
Date: Sat, 02 Sep 2017 12:45:15 +0200	[thread overview]
Message-ID: <87mv6dl6pw.fsf@fastmail.com> (raw)
In-Reply-To: <20170828212419.67jazbi5fzouyki3@abyayala>

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

ng0 <ng0@infotropique.org> writes:

> Updated patch with a small comment grammar fix.
>
> Purpose of this patch: to add a dependency which was
> previously unknown and had to be figured out by the
> person who would try to fix the tests. So to go from
> "nothing, uh what do we need here?" to
> "hey, we have the test dependency" is an improvement
> and not just a "work in progress" one-liner.

Right.  I don't think adding dependencies that does not change anything
with the package is very useful.  A comment stating that this dependency
would be needed to enable tests would do the same purpose without
changing the derivation.  But, it would take any packager about 20
seconds to find that Test::Simple is needed, so it's kind of "stating
the obvious".

Anyway I tried building this package with tests enabled and just kept
adding the modules it could not find as native-inputs until it
succeeded.  So I pushed a superset of this patch as
3fe666aa29e72a9fbb1e267eebcd7d197ec802f3.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2017-09-02 10:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-27 18:28 [bug#28253] perl-www-opensearch: provide Test-Simple module ng0
2017-08-28 20:28 ` bug#28253: " Marius Bakke
2017-08-28 20:59   ` [bug#28253] " ng0
2017-08-28 21:24     ` ng0
2017-09-02 10:45       ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv6dl6pw.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=28253-done@debbugs.gnu.org \
    --cc=ng0@infotropique.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).