From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr1kT-0000o1-67 for guix-patches@gnu.org; Sun, 10 Sep 2017 08:54:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dr1kS-0001Jh-7x for guix-patches@gnu.org; Sun, 10 Sep 2017 08:54:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dr1kS-0001JW-3t for guix-patches@gnu.org; Sun, 10 Sep 2017 08:54:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dr1kQ-0006SL-5t for guix-patches@gnu.org; Sun, 10 Sep 2017 08:54:03 -0400 Subject: [bug#28384] [PATCH] gnu: Fix build failures caused by commit. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170907164340.32328-1-kkebreau@posteo.net> <87o9ql9oxa.fsf@gnu.org> <87377xdtwy.fsf@posteo.net> <87efrh9bhk.fsf@gnu.org> <87y3podepl.fsf@posteo.net> Date: Sun, 10 Sep 2017 14:53:32 +0200 In-Reply-To: <87y3podepl.fsf@posteo.net> (Kei Kebreau's message of "Fri, 08 Sep 2017 18:10:14 -0400") Message-ID: <87mv6290kz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau Cc: 28384@debbugs.gnu.org Kei Kebreau skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Kei Kebreau skribis: >> >>> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>> >>>> Hi Kei, >>>> >>>> The subject is truncated. :-) Caused by which commit? >>>> >>>> Kei Kebreau skribis: >>>> >>>>> * gnu/packages/bioinformatics.scm (seek)[arguments]: Modify unpack ph= ase. >>>>> * gnu/packages/ci.scm (cuirass)[arguments]: Add patch-/bin/sh phase. >>>> >>>> This is weird, normally the =E2=80=98patch-source-shebangs=E2=80=99 ph= ase, which happens >>>> right before =E2=80=98configure=E2=80=99, should take care of these, n= o? >>>> >>> >>> Normally the 'patch-source-shebangs' does just that, but in this case >>> the script needs to be patched because the bootstrapping phase depends >>> on perl. >> >> OK. I don=E2=80=99t understand at what point this became necessary thou= gh. >> > > It's probably a result of moving the 'bootstrap' phase before the > 'patch-source-shebangs' phase. Without this change, the seek package > builds fine. I have no preference either way, though I notice that the > same thing is done for guile-for-guile-emacs. Since this commit was just about changing the syntax, not the semantics, I would expect it to keep phases in the same order. That would be more concise than adding custom code to patch things here and there, no? WDYT? >>> From 87ea8addad973568d8599fb93c8df9766b96b6a1 Mon Sep 17 00:00:00 2001 >>> From: Kei Kebreau >>> Date: Sat, 29 Jul 2017 11:28:42 -0400 >>> Subject: [PATCH] gnu: Use 'modify-phases' syntax. >>> To: guix-patches@gnu.org >> >> Wrong patch. :-) >> >> Ludo=E2=80=99. > > Fixed! > > From d9eee184cf80252092c34864d492527ee768a7fb Mon Sep 17 00:00:00 2001 > From: Kei Kebreau > Date: Thu, 7 Sep 2017 09:36:28 -0400 > Subject: [PATCH] gnu: Fix build failures caused by commit > d10092b849153dc27cfed0a9601fde6c7bdec918. > > * gnu/packages/bioinformatics.scm (seek)[arguments]: Modify unpack phase. > * gnu/packages/ci.scm (cuirass)[arguments]: Add patch-/bin/sh phase. That=E2=80=99s fine with me, even though I have a slight preference for sim= ply restoring the order of phases as it was before. Thanks! Ludo=E2=80=99.