From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eljnx-0003yq-GK for guix-patches@gnu.org; Tue, 13 Feb 2018 18:16:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eljnu-00054V-Ax for guix-patches@gnu.org; Tue, 13 Feb 2018 18:16:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:34025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eljnu-00054J-2K for guix-patches@gnu.org; Tue, 13 Feb 2018 18:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eljnt-0004s3-Mg for guix-patches@gnu.org; Tue, 13 Feb 2018 18:16:01 -0500 Subject: [bug#30334] [PATCH] gnu: Add dtrx. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180203132914.6649-1-h.goebel@crazy-compilers.com> References: <20180203132914.6649-1-h.goebel@crazy-compilers.com> Date: Wed, 14 Feb 2018 00:15:32 +0100 Message-ID: <87mv0cwkff.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Hartmut Goebel , 30334@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hartmut Goebel writes: > * gnu/packages.compression.scm (dtrx): New variable. [...] > @@ -53,10 +54,12 @@ > #:use-module (gnu packages backup) > #:use-module (gnu packages base) > #:use-module (gnu packages check) > + #:use-module (gnu packages cpio) > #:use-module (gnu packages curl) > #:use-module (gnu packages file) > #:use-module (gnu packages java) > #:use-module (gnu packages maths) > + #:use-module (gnu packages package-management) > #:use-module (gnu packages perl) > #:use-module (gnu packages perl-check) > #:use-module (gnu packages pkg-config) I wonder if there are other places to put this package. (gnu packages compression) is starting to have a lot of top-level cross-module references. Though I'm not sure what consequences it has in practice. > +(define-public dtrx > + (package > + (name "dtrx") > + (version "7.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://brettcsmith.org/2007/" > + "dtrx/dtrx-" version ".tar.gz")) > + (sha256 > + (base32 "15yf4n27zbhvv0byfv3i89wl5zn6jc2wbc69lk5a3m6rx54gx6hw"))= )) > + (build-system python-build-system) > + (arguments > + `(#:python ,python-2)) > + (inputs > + `(("binutils" ,binutils) ; ar > + ("bzip2" ,bzip2) ; bzcat > + ("cabextract" ,cabextract) > + ("cpio" ,cpio) ; cpio > + ("gzip" ,gzip) ; zcat > + ;; ("lha" ,lha) missing in guix > + ("p7zip" ,p7zip) ; 7z > + ("rpm" ,rpm) ; rpm2cpio > + ("tar" ,tar) > + ;; ("unrar" ,unrar) ; abandoned upstream The canonical unrar is also non-free, so I think we should remove this line entirely, so that we don't direct potential contributors to it. > + ("unshield" ,unshield) > + ("unzip" ,unzip) > + ("xz" ,xz))) ; lzcat, xzcat Does dtrx actually keep references to all of these (as verified with `guix gc -R`)? > + (home-page "http://www.brettcsmith.org/2007/dtrx/") > + (synopsis "Intelligently extract multiple archive types") > + (description "@command{dtrx} extracts archives in a number of differ= ent > +formats, so you don't have to remember the flags for each archive comman= d. > +Just use the same command for all your archive files, and they'll never > +frustrate you again. > + > +In addition to providing one command to handle many different archive ty= pes, > +@command{dtrx} also aids the user by extracting contents consistently. = By > +default, everything will be written to a dedicated directory that=E2=80= =99s named > +after the archive. dtrx will also change the permissions to ensure that= the > +owner can read and write all those files. > + > +It currently supports tar, zip (including self-extracting .exe files), c= pio, > +rpm, deb, gem, 7z, cab, rar, and InstallShield files. It can also decom= press > +files compressed with gzip, bzip2, lzma, xz, or compress.") I think we should not mention formats that are not currently supported, so as to not confuse users who search for e.g. rar and tries installing this. Or maybe remove this last paragraph entirely to ease maintenance, WDYT? Just in case there is a new upstream release after all these years. LGTM otherwise (assuming it works!). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqDcZQACgkQoqBt8qM6 VPp8aggAveAtW1KtvoCIeWVhz4QFS4bM+uVZ13ZXouBoD57cSxspjP7j729KzhTc W+idu4OcemqYUERV2BRDiCnKbmnT0oSWFL1owcMgmzmQIiK/P0MNeRvIyQxKmtp2 YzGmzaITlXeHCZN2A/j6mNFRvmnQyRQrQBGknkiR+1reL1/e9D8AzZCO8rrSIHWd 8Z3bV1TxMhSNWzYibultxfb57FWzGSmaG66Aws9lgo9oL71wOsD4+dpOfY5vsaGg iOTl2MuWGNGkPrDDv821IYVQnX/09y+HiwhiMaSLV+M7meLVNBkf9q+QAaV+s7HT m8rffgQ8zTgQXjwEzjImrgW+WjblOQ== =Ngis -----END PGP SIGNATURE----- --=-=-=--