From: Christopher Baines <mail@cbaines.net>
To: Alex Kost <alezost@gmail.com>
Cc: 30698-done@debbugs.gnu.org
Subject: bug#30698: [PATCH 1/2] gnu: Add emacs-hcl-mode.
Date: Mon, 05 Mar 2018 07:50:23 +0000 [thread overview]
Message-ID: <87muznota8.fsf@cbaines.net> (raw)
In-Reply-To: <877eqreglf.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]
Alex Kost <alezost@gmail.com> writes:
> Christopher Baines (2018-03-04 16:50 +0000) wrote:
>
>> * gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
>> ---
>> gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 69950cc6d..0e46c71f1 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -7313,3 +7313,26 @@ Features:
>> (description "@code{epipe} provides an utility to use your editor in
>> the pipeline, featuring the support for running @code{emacsclient}.")
>> (license license:gpl3+)))
>> +
>> +(define-public emacs-hcl-mode
>> + (package
>> + (name "emacs-hcl-mode")
>> + (version "0.03")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://github.com/syohex/emacs-hcl-mode/archive/"
>> + version ".tar.gz"))
>> + (file-name (string-append name "-" version ".tar.gz"))
>> + (sha256
>> + (base32
>> + "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://github.com/syohex/emacs-hcl-mode")
>> + (synopsis "Major mode for the Hashicorp Configuration Language")
>> + (description
>> + "@code{emacs-hcl-mode} provides an Emacs major mode for working with
>> +@acronym{HCL, Hashicorp Configuration Language}. It provides syntax
>> +highlighting and indentation support. ")
> ^ extra space
> otherwise, looks good to me, thank you!
Great, I've removed the space, and pushed both of these patches. Thanks
for your review :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
prev parent reply other threads:[~2018-03-05 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 16:46 [bug#30698] [PATCH 0/2] Add Emacs packages for HCL and Terraform Christopher Baines
2018-03-04 16:50 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Christopher Baines
2018-03-04 16:50 ` [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode Christopher Baines
2018-03-04 20:21 ` Alex Kost
2018-03-05 7:44 ` Christopher Baines
2018-03-04 20:22 ` [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode Alex Kost
2018-03-05 7:50 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muznota8.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=30698-done@debbugs.gnu.org \
--cc=alezost@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).