unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>, 31123@debbugs.gnu.org
Subject: [bug#31123] [PATCH 2/2] gnu: texlive-bin: Patch texlua shebangs.
Date: Tue, 17 Apr 2018 00:08:16 +0200	[thread overview]
Message-ID: <87muy2dctr.fsf@fastmail.com> (raw)
In-Reply-To: <20180411060313.27912-2-arunisaac@systemreboot.net>

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Arun Isaac <arunisaac@systemreboot.net> writes:

> * gnu/packages/tex.scm (texlive-bin)[arguments]: Patch texlua shebangs in
> postint phase.

[...]

>                 (with-directory-excursion "texlive-extra"
>                   (apply unpack (list #:source texlive-extra))
>                   (apply patch-source-shebangs (list #:source texlive-extra))
> -                 (invoke "mv" "tlpkg" share))))))))
> +                 (invoke "mv" "tlpkg" share))
> +               ;; texlua shebangs are not patched by the patch-source-shebangs
> +               ;; phase because the texlua executable does not exist at that
> +               ;; time.
> +               (setenv "PATH" (string-append (getenv "PATH") ":" out "/bin"))
> +               (with-directory-excursion out
> +                 (patch-source-shebangs))))))))

Would it suffice to only patch "out/bin" here?

Also, what is the return value of (patch-source-shebangs)?  If it's
anything other than #t, you know what to do.  Apart from that LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2018-04-16 22:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11  5:59 [bug#31123] [PATCH 0/2] texlive-bin bug fixes Arun Isaac
2018-04-11  6:03 ` [bug#31123] [PATCH 1/2] gnu: texlive-bin: Use ghostscript executable "gs" in ps2eps Arun Isaac
2018-04-11  6:03   ` [bug#31123] [PATCH 2/2] gnu: texlive-bin: Patch texlua shebangs Arun Isaac
2018-04-16 22:08     ` Marius Bakke [this message]
2018-04-19 17:33       ` Arun Isaac
2018-04-19 17:42         ` Marius Bakke
2018-04-20 19:13           ` bug#31123: " Arun Isaac
2018-04-20 18:45       ` [bug#31123] " Arun Isaac
2018-04-16 22:05   ` [bug#31123] [PATCH 1/2] gnu: texlive-bin: Use ghostscript executable "gs" in ps2eps Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muy2dctr.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=31123@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).