From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fK8kp-0007zU-8a for guix-patches@gnu.org; Sat, 19 May 2018 16:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fK8ko-000851-2g for guix-patches@gnu.org; Sat, 19 May 2018 16:47:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fK8kn-00084p-V8 for guix-patches@gnu.org; Sat, 19 May 2018 16:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fK8kn-00010D-Nu for guix-patches@gnu.org; Sat, 19 May 2018 16:47:01 -0400 Subject: [bug#31494] [PATCH] gnu: gifsicle: New variable. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180518150002.24615-1-ambrevar@gmail.com> Date: Sat, 19 May 2018 22:46:48 +0200 In-Reply-To: <20180518150002.24615-1-ambrevar@gmail.com> (Pierre Neidhardt's message of "Fri, 18 May 2018 17:00:02 +0200") Message-ID: <87muwvnzk7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 31494@debbugs.gnu.org Hi, Pierre Neidhardt skribis: > * gnu/packages/image.scm (gifsicle): New variable. Copyright line please. :-) > + (build-system gnu-build-system) > + ;; TODO: Tests fail with "undefined error at undefined point in scrip= t". > + ;; They pass when run manually with > + ;; guix environment gifsicle -- ./test/testie -p src/ test/ > + (arguments '(#:tests? #f)) > + ;; (arguments > + ;; '(#:phases > + ;; (modify-phases %standard-phases > + ;; (add-before 'check 'patch-tests > + ;; (lambda _ > + ;; (substitute* "test/testie" > + ;; (("/usr/bin/perl") > + ;; (which "perl")) > + ;; (("/bin/rm") > + ;; (which "rm")))))))) > + ;; (native-inputs `(("perl" ,perl))) ; Only for tests. Could the test failures be caused by other hardcoded file names (like =E2=80=9C/bin/sh=E2=80=9D)? If they pass in =E2=80=99guix environment=E2= =80=99 that may well be the reason. > + (inputs `(("libx11" ,libx11))) > + (home-page "http://www.lcdf.org/gifsicle/") > + (synopsis "Create, edit, manipulate and get information about GIF ima= ges and animations") To shorten a bit, what about: =E2=80=9CEdit GIF images and animations=E2=80= =9D? > + (description "Some Gifsicle features: > +- Batch mode for changing GIFs in place. > +- Prints detailed information about GIFs, including comments. > +- Control over interlacing, comments, looping, transparency... > +- Creates well-behaved GIFs: removes redundant colors, only uses local c= olor > +tables if it absolutely has to (local color tables waste space and can c= ause > +viewing artifacts), etc. > +- It can shrink colormaps and change images to use the Web-safe palette = (or > +any colormap you choose). > +- Optimize your animations! This stores only the changed portion of each > +frame, and can radically shrink your GIFs. You can also use transparency= to > +make them even smaller. Gifsicle's optimizer is pretty powerful, and usu= ally > +reduces animations to within a couple bytes of the best commercial optim= izers. > +- Unoptimizing animations, which makes them easier to edit. > + > +Two other programs are included with Gifsicle: @code{gifview} is a light= weight > +animated-GIF viewer which can show animations as slideshows or in real t= ime, > +and @code{gifdiff} compares two GIFs for identical visual appearance. ") Please @itemize and full sentences. Could you send an updated patch? Thank you! Ludo=E2=80=99.