unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#32775] [PATCH] gnu: Add gandi.cli.
@ 2018-09-19 20:53 Tobias Geerinckx-Rice
  2018-09-19 22:02 ` Leo Famulari
  2018-09-24 20:27 ` bug#32775: " Tobias Geerinckx-Rice
  0 siblings, 2 replies; 5+ messages in thread
From: Tobias Geerinckx-Rice @ 2018-09-19 20:53 UTC (permalink / raw)
  To: 32775

* gnu/packages/networking.scm (gandi.cli): New public variable.
---

Don't judge me.                                                                                                 

 gnu/packages/networking.scm | 50 +++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index abc616de3..f30d5a8da 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -87,6 +87,7 @@
   #:use-module (gnu packages perl-check)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-web)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages ssh)
@@ -673,6 +674,55 @@ send out a ping packet and move on to the next target in a round-robin
 fashion.")
     (license license:expat)))
 
+(define-public gandi.cli
+  (package
+    (name "gandi.cli")
+    (version "1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri name version))
+       (sha256
+        (base32 "0vfzkw1avybjkf6fwqpf5m4kjz4c0qkkmj62f3jd0zx00vh5ly1d"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'embed-store-file-names
+           (lambda _
+             (substitute* (list "gandi/cli/modules/cert.py"
+                                "gandi/cli/tests/commands/test_certificate.py")
+               (("openssl") (which "openssl")))
+             #t))
+         (add-after 'install 'install-documentation
+           ;; The included man page may be outdated but we install it anyway,
+           ;; since it's mentioned in 'gandi --help' and better than nothing.
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out  (assoc-ref outputs "out"))
+                    (man1 (string-append out "/share/man/man1")))
+               (mkdir-p man1)
+               (with-output-to-file (string-append man1 "/gandi.1")
+                 (lambda _
+                   (invoke "rst2man.py" "gandicli.man.rst")))
+               #t))))))
+    (native-inputs
+     `(("python-docutils" ,python-docutils)   ; for rst2man.py
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-tox" ,python-tox)))
+    (inputs
+     `(("openssl" ,openssl)
+       ("python-click" ,python-click)
+       ("python-ipy" ,python-ipy)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)))
+    (home-page "https://cli.gandi.net")
+    (synopsis "Command-line interface to the Gandi.net API")
+    (description
+     "This package provides a command-line client (@command{gandi}) to buy,
+manage, and delete Internet resources from Gandi.net such as domain names,
+virtual machines, and certificates.")
+    (license license:gpl3+)))
+
 (define-public httping
   (package
     (name "httping")
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#32775] [PATCH] gnu: Add gandi.cli.
  2018-09-19 20:53 [bug#32775] [PATCH] gnu: Add gandi.cli Tobias Geerinckx-Rice
@ 2018-09-19 22:02 ` Leo Famulari
  2018-09-24 12:23   ` Ludovic Courtès
  2018-09-24 20:27 ` bug#32775: " Tobias Geerinckx-Rice
  1 sibling, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2018-09-19 22:02 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: 32775

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Wed, Sep 19, 2018 at 10:53:47PM +0200, Tobias Geerinckx-Rice wrote:
> * gnu/packages/networking.scm (gandi.cli): New public variable.

Thanks!

> +(define-public gandi.cli
> +  (package
> +    (name "gandi.cli")

I prefer 'gandi-cli', but it's your call. The manual section Package
Naming only specifies how to replace underscores.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#32775] [PATCH] gnu: Add gandi.cli.
  2018-09-19 22:02 ` Leo Famulari
@ 2018-09-24 12:23   ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2018-09-24 12:23 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 32775

Leo Famulari <leo@famulari.name> skribis:

> On Wed, Sep 19, 2018 at 10:53:47PM +0200, Tobias Geerinckx-Rice wrote:
>> * gnu/packages/networking.scm (gandi.cli): New public variable.
>
> Thanks!
>
>> +(define-public gandi.cli
>> +  (package
>> +    (name "gandi.cli")
>
> I prefer 'gandi-cli', but it's your call. The manual section Package
> Naming only specifies how to replace underscores.

I also have a slight preference to a hyphen, FWIW.  :-)

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#32775: [PATCH] gnu: Add gandi.cli.
  2018-09-19 20:53 [bug#32775] [PATCH] gnu: Add gandi.cli Tobias Geerinckx-Rice
  2018-09-19 22:02 ` Leo Famulari
@ 2018-09-24 20:27 ` Tobias Geerinckx-Rice
  2018-09-24 20:34   ` [bug#32775] " Leo Famulari
  1 sibling, 1 reply; 5+ messages in thread
From: Tobias Geerinckx-Rice @ 2018-09-24 20:27 UTC (permalink / raw)
  To: 32775-done

Leo, Ludo',

I pushed this patch as-is earlier today...

Ludo' wrote:
> Leo Famulari <leo@famulari.name> skribis:
>>> +    (name "gandi.cli")
>>
>> I prefer 'gandi-cli', but it's your call. The manual section 
>> Package
>> Naming only specifies how to replace underscores.

...having read this...

> I also have a slight preference to a hyphen, FWIW.  :-)

...but not this.

My vote's to follow upstream as long as upstream's not too silly, 
and not further restrict package names without good reason. Or is 
anyone's objection more than aesthetic?

Note that there are already other — mostly Python — packages that 
keep the '.' in their name. I checked before adding this one :-)

  $ ./pre-inst-env guix package -A '[^0-9]\.|\.[^0-9]' # and skip 
  some Go stuff
  proj.4	4.9.3	out	gnu/packages/geo.scm:294:2
  python{,2}-oslo.config	5.2.0	out 
  gnu/packages/openstack.scm:381:2
  python{,2}-oslo.context	2.20.0	out 
  gnu/packages/openstack.scm:423:2
  python{,2}-oslo.i18n	3.20.0	out 
  gnu/packages/openstack.scm:453:2
  python{,2}-oslo.log	3.36.0	out 
  gnu/packages/openstack.scm:486:2
  python{,2}-oslo.serialization	2.24.0	out 
  gnu/packages/openstack.scm:527:2
  python{,2}-oslo.utils	3.36.2	out 
  gnu/packages/openstack.scm:681:2
  python{,2}-rst.linker	1.10	out 
  gnu/packages/python.scm:2662:2
  python{,2}-ruamel.yaml	0.15.37	out 
  gnu/packages/serialization.scm:367:2
  python2-elib.intl	0.0.3	out 
  gnu/packages/python.scm:4052:2
  python2-ruamel.ordereddict	0.4.9	out 
  gnu/packages/python.scm:10965:2
  ruby-http-parser.rb	0.6.0	out 
  gnu/packages/ruby.scm:5754:2

Meh,

T G-R

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#32775] [PATCH] gnu: Add gandi.cli.
  2018-09-24 20:27 ` bug#32775: " Tobias Geerinckx-Rice
@ 2018-09-24 20:34   ` Leo Famulari
  0 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2018-09-24 20:34 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: 32775-done

Use the dot.

:)

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-09-24 20:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-19 20:53 [bug#32775] [PATCH] gnu: Add gandi.cli Tobias Geerinckx-Rice
2018-09-19 22:02 ` Leo Famulari
2018-09-24 12:23   ` Ludovic Courtès
2018-09-24 20:27 ` bug#32775: " Tobias Geerinckx-Rice
2018-09-24 20:34   ` [bug#32775] " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).