From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBt67-0000l3-SZ for guix-patches@gnu.org; Sun, 14 Oct 2018 22:59:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBt62-0004HU-Kv for guix-patches@gnu.org; Sun, 14 Oct 2018 22:59:11 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gBt5y-0004FX-UW for guix-patches@gnu.org; Sun, 14 Oct 2018 22:59:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gBt5y-0004ua-P4 for guix-patches@gnu.org; Sun, 14 Oct 2018 22:59:02 -0400 Subject: bug#32565: [PATCHv3] Add python-falcon, python-falcon-cors. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Maxim Cournoyer References: <87va7tak4m.fsf@apteryx.i-did-not-set--mail-host-address--so-tickle-me> <87r2ihaiw6.fsf_-_@gmail.com> <87efebad2p.fsf_-_@gmail.com> <87d0tdfakk.fsf@gnu.org> Date: Sun, 14 Oct 2018 22:58:05 -0400 In-Reply-To: <87d0tdfakk.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 16 Sep 2018 22:31:55 +0200") Message-ID: <87murf9arm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 32565-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, Sorry for keeping you waiting this long, and thank you for the friendly ping! I've addressed the points of your review below. ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >>>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001 >> From: Maxim Cournoyer >> Date: Wed, 29 Aug 2018 00:06:28 -0400 >> Subject: [PATCH 1/2] gnu: Add python-falcon. >> >> * gnu/packages/python-web.scm (python-falcon): New variable. > > [...] > >> + (home-page "https://falconframework.org") >> + (synopsis >> + "Unladen web framework for building APIs and app backends") >> + (description >> + "Falcon is a bare-metal Python web API framework for building >> +high-performance microservices, app backends, and higher-level framewor= ks.") > > If you could make it a bit less catchy and more concrete (giving example > of actual features), that would be great. :-) I've modified it like so: =2D-8<---------------cut here---------------start------------->8--- =2D "Unladen web framework for building APIs and app backends") + "Web framework for building APIs and application backends") (description =2D "Falcon is a bare-metal Python web API framework for building =2Dhigh-performance microservices, app backends, and higher-level framework= s.") + "Falcon is a web API framework for building microservices, application +backends and higher-level frameworks. Among its features are: +@itemize +@item Optimized and extensible code base +@item Routing via URI templates and REST-inspired resource +classes +@item Access to headers and bodies through request and response +classes +@item Request processing via middleware components and hooks +@item Idiomatic HTTP error responses +@item Straightforward exception handling +@item Unit testing support through WSGI helpers and mocks +@item Compatible with both CPython and PyPy +@item Cython support for better performance when used with CPython +@end itemize") (license license:asl2.0))) =2D-8<---------------cut here---------------end--------------->8--- I mostly took the feature list from their home page and removed some extraneous adjectives that made it sound overly catchy. >>>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001 >> From: Maxim Cournoyer >> Date: Wed, 29 Aug 2018 00:33:17 -0400 >> Subject: [PATCH 2/2] gnu: Add python-falcon-cors. >> >> * gnu/packages/python-web.scm (python-falcon-cors): New variable. > > [...] > >> + (home-page >> + "https://github.com/lwcolton/falcon-cors") >> + (synopsis "Falcon CORS middlware") > ^^ > Typo. Fixed. > What about =E2=80=9CFalcon @dfn{cross-origin resource sharing} (CORS) lib= rary=E2=80=9D? Good idea. >> + (description "This middleware provides CORS support for Falcon.") > > Ditto here, and bonus points if you add a couple of sentences to explain > what it does concretely. :-) I tried doing so like here: =2D-8<---------------cut here---------------start------------->8--- =2D (synopsis "Falcon CORS middlware") =2D (description "This middleware provides CORS support for Falcon.") + (synopsis "Falcon @dfn{cross-origin resource sharing} (CORS) library") + (description "This middleware provides @dfn{cross-origin resource +sharing} (CORS) support for Falcon. It allows applying a specially crafted +CORS object to the incoming requests, enabling the ability to serve resour= ces +over a different origin than that of the web application.") =2D-8<---------------cut here---------------end--------------->8--- To go further than this would require explaining what CORS is about, which = is not the right place in my opinion :). > Last point: unless you need them, you can remove the =E2=80=9Cpython2-=E2= =80=9D variants > since Python 2.x is reaching end-of-life. Sadly, yes, I need them. > OK to push with changes along these lines. Pushed as 66a9f08bb9c9ba2d7cd4ee3c2d48ea9a8e41c2c4. Thank you for the review :) Maxim --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAlvEAj0ACgkQEmDkZILm NWI3gw/7BJSeg4oPow5TFg2LhKDCujphkWeb/oDGims9NeqVgxGgzbeZQx8hLRjR n8EYVYeQWKbIAsns6XLbjAzF2T2WM4G0s9CGoHgPXi21LsjAxjQeCmKKb+YcWHA1 pgEM23N/QfoAApOXejDyB4vrmBTIpGAjKDwOjeEOSAMekv7gkQErY8uWYzQwUBF5 TR5olAnnS3msQeRxzuvlaC71NwIpgeEIFtSPlpLOd+g2mCy04IlH5imo7FA+xjfQ EDUc2+yVQ3AXJAac9BENMxRvoGTqTp6INN7g4YEeB8VNU9Gtk/i2BO1HtNexGzh/ 9zVBtje4pJuku1UXkSQjkex7EHIhOb7ca05U3Sn9hTwnMAtoyTmPcd7yFtiac7WS BiFYH4xQKxsyDCKf/DAQhzcNiS4Ydf7lqOtT/OwEz1f2LTe9AqwNsHH6DiIAjmAw sXWdPnpKux9t7jZlxa0ow718fCWppAXQosQVhgMjrNqVlgsGP93cdj7U92IxsAaT XYbqDzqHUq7rbYIG3UAKRYmuOA662oPgU9DSw2CXAsAZrdOEOcK+PAjzQAhGQgGv mzmHVOBcJIGH/qzWgi2rloERcQB7uo2MK4+YubFOrefJdAehODW2iF4RUQ3P9L9d LziIbZRFrqZg8PkCJ5upbf01GqnbloCou/vtIPcob0IMM94JfWk= =UFUz -----END PGP SIGNATURE----- --=-=-=--