From: "Ludovic Courtès" <ludo@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 34917@debbugs.gnu.org
Subject: [bug#34917] [PATCH v2] gnu: docker: Use fewer modprobes.
Date: Fri, 22 Mar 2019 22:48:02 +0100 [thread overview]
Message-ID: <87mulm1sz1.fsf@gnu.org> (raw)
In-Reply-To: <20190319182648.20666-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Tue, 19 Mar 2019 19:26:48 +0100")
Hello,
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> Fixes <https://bugs.gnu.org/34333>.
> Reported by Allan Adair <allan@adair.io>.
>
> * gnu/packages/patches/docker-use-fewer-modprobes.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/docker.scm (docker)[source]: Use it.
> --- /dev/null
> +++ b/gnu/packages/patches/docker-use-fewer-modprobes.patch
> @@ -0,0 +1,116 @@
> +This patch makes docker find out whether a filesystem type is supported
> +by trying to mount a filesystem of that type rather than invoking "modprobe".
Nice! What this patch does looks like the right thing to me, certainly
better than invoking modprobe (who thought Docker would do that?!).
Did you submit it upstream? It’d be nice to get their feedback, and
also have a tracking URL in the patch.
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2019-03-22 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 18:20 [bug#34917] [PATCH] gnu: docker: Use fewer modprobes Danny Milosavljevic
2019-03-19 18:26 ` [bug#34917] [PATCH v2] " Danny Milosavljevic
2019-03-22 21:48 ` Ludovic Courtès [this message]
2019-03-25 19:27 ` Danny Milosavljevic
2019-03-25 21:27 ` Ludovic Courtès
2019-03-30 10:41 ` bug#34917: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mulm1sz1.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=34917@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).