unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 35482@debbugs.gnu.org
Subject: [bug#35482] [PATCH] Rename games to match upstream name project
Date: Mon, 29 Apr 2019 09:30:19 +0200	[thread overview]
Message-ID: <87muk9jmk4.fsf@gnu.org> (raw)
In-Reply-To: <87r29lg4xk.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 29 Apr 2019 00:07:03 +0200")

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> I remember there was some discussion about them, but I don't know what
> was its conclusion. 

Several people were in favor of reverting the name changes.

> In any case, for the time being, some games use a "pretty name", e.g.,
> "l-abbaye-des-morts", whereas others do not, e.g., "alex4". I think this
> should be settled before 1.0 release. Hence, for the sake of
> consistency, the following patch reverts all games back to their
> original name.

I’m all for it, thanks for taking the time to do it.  (That’s another
reason why this big-rename patch should have gone through review: once
committed, it remained, even though consensus was reached to revert it;
not a great situation!)

>>From 52fa4205c56184782749b5bec244dda6c9023b3e Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Sun, 28 Apr 2019 23:49:00 +0200
> Subject: [PATCH] gnu: Rename some games to match upstream project name.
>
> * gnu/packages/games.scm (armagetronad):
> (cataclysm-dda):
> (abbaye):
> (wesnoth):
> (wesnoth-server):
> (starfighter):
> (kiki):
> (fillets-ng):
> (crawl):
> (crawl-tiles):
> (tome4):
> (btanks):
> (battle-tanks):
> (edgar): Use these as the package definition.
> (armagetron-advanced):
> (cataclysm-dark-days-ahead):
> (l-abbaye-des-morts):
> (the-battle-for-wesnoth):
> (the-battle-for-wesnoth-server):
> (project-starfighter):
> (kiki-the-nano-bot):
> (fish-fillets-ng):
> (dungeon-crawl-stone-soup):
> (dungeon-crawl-stone-soup-tiles):
> (tales-of-maj-eyal):
> (the-legend-of-edgar): Turn these into obsolete aliases.

Please add a line like “This reverts renames made by commit XYZ.”

Just double-check that there are no unbound variables or anything like
that, after applying Tobias’ changes, and then go for it!

Thank you,
Ludo’.

  parent reply	other threads:[~2019-04-29  7:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-28 22:07 [bug#35482] [PATCH] Rename games to match upstream name project Nicolas Goaziou
2019-04-28 23:02 ` Tobias Geerinckx-Rice
2019-04-29  7:30 ` Ludovic Courtès [this message]
2019-04-30  0:13   ` bug#35482: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muk9jmk4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=35482@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).