unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 36807@debbugs.gnu.org
Subject: [bug#36807] remove obsolete broken haskell packages
Date: Thu, 25 Jul 2019 09:29:56 -0400	[thread overview]
Message-ID: <87muh2ckdn.fsf@ngyro.com> (raw)
In-Reply-To: <F5E8BA95-BE79-4579-B881-AE0862B69D3A@vllmrt.net> (Robert Vollmert's message of "Thu, 25 Jul 2019 13:40:58 +0200")

Hi Robert,

Robert Vollmert <rob@vllmrt.net> writes:

> This series removes some outdated packages that don’t build and
> aren’t depend on.

I remember that we intended to remove these last year.  Indeed, Ricardo
mentioned it when we were finishing up the upgrade to GHC 8.4:

    https://lists.gnu.org/archive/html/guix-devel/2018-09/msg00330.html

Based on that, we could also get rid of “ghc-packedstring” if it doesn’t
have any dependants.

Now for my usual commit message nit-picking.  :)  You should drop the
parenthetical “broken and unused” note and add a period to the end of
the first line, like this:

    gnu: Remove ghc-regex-tdfa-rc.

One of the commits says “It...” and the other says “This package...”.
They might as well be the same.  Lastly, it’s usually “remove variable”
instead of “remove package”.

Other than that, LGTM.  Thanks!  (Do you have commit access now or
should I push these?)


-- Tim

  parent reply	other threads:[~2019-07-25 13:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25 11:40 [bug#36807] remove obsolete broken haskell packages Robert Vollmert
2019-07-25 11:45 ` [bug#36807] [PATCH] gnu: Remove ghc-regex-tdfa-rc (broken and unused) Robert Vollmert
2019-07-25 11:46 ` [bug#36807] [PATCH] gnu: Remove ghc-haddock-test " Robert Vollmert
2019-07-25 13:29 ` Timothy Sample [this message]
2019-08-01 16:23   ` [bug#36807] Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages) Robert Vollmert
     [not found]     ` <87mugmq5ll.fsf@ngyro.com>
     [not found]       ` <3C8EAC60-7073-4528-BC5D-548A018F08D8@vllmrt.net>
     [not found]         ` <878ss4pbkg.fsf@ngyro.com>
2019-08-08  4:28           ` bug#36807: " Timothy Sample

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muh2ckdn.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=36807@debbugs.gnu.org \
    --cc=rob@vllmrt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).