From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47780) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikYHn-0000Qf-Cn for guix-patches@gnu.org; Thu, 26 Dec 2019 13:55:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikYHm-0000ta-Eb for guix-patches@gnu.org; Thu, 26 Dec 2019 13:55:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50275) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ikYHm-0000tW-BP for guix-patches@gnu.org; Thu, 26 Dec 2019 13:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ikYHm-0000f2-B1 for guix-patches@gnu.org; Thu, 26 Dec 2019 13:55:02 -0500 Subject: [bug#38612] Pass system and target arguments to gexp->file. Resent-Message-ID: References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87imm468rr.fsf@gmail.com> <87d0cbhsk1.fsf@gnu.org> From: Mathieu Othacehe In-reply-to: <87d0cbhsk1.fsf@gnu.org> Date: Thu, 26 Dec 2019 19:54:45 +0100 Message-ID: <87mubej4sq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 38612@debbugs.gnu.org Hey, > In general, in monadic code, we should refer to (current-system) and > (current-target-system), not to the SRFI-39 parameters. Ok! > By default, =E2=80=98gexp->file=E2=80=99 now uses the current system and = target, so this > change shouldn=E2=80=99t be necessary if you just want to use those. Am I > missing something? Well turns out that gexp->file takes #f as default target (as gexp->script and lower-object). Using %current-target-system as default target argument (as gexp->sexp) makes those two patches useless. Would you have any objection to use %current-target-system as default target argument in gexp->file and lower-object? Thanks, Mathieu