From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 39717@debbugs.gnu.org
Subject: [bug#39717] [PATCH 1/3] gnu: delft-icon-theme: Use the copy-build-system.
Date: Thu, 27 Feb 2020 11:27:49 +0100 [thread overview]
Message-ID: <87mu9472ai.fsf@ambrevar.xyz> (raw)
In-Reply-To: <20200221163215.11008-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Fri, 21 Feb 2020 17:32:13 +0100")
[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]
Thanks for the patch!
Comments below:
> (arguments
> - `(#:modules ((guix build utils))
> - #:builder
> - (begin
> - (use-modules (guix build utils))
> - (copy-recursively (assoc-ref %build-inputs "source") "icons")
> - (substitute* "icons/Delft/index.theme"
> - (("gnome") "Adwaita"))
> - (delete-file "icons/README.md")
> - (delete-file "icons/LICENSE")
> - (delete-file "icons/logo.jpg")
> - (copy-recursively "icons" (string-append %output "/share/icons")))))
> + `(#:install-plan
> + '(,@(append-map (lambda (file)
> + `((,file "share/icons/")
> + (,(string-append file "-Dark") "share/icons/")
> + (,(string-append file "-Darker") "share/icons/")
> + (,(string-append file "-Darkest") "share/icons/")))
> + '("Delft" "Delft-Amber" "Delft-Aqua" "Delft-Blue"
> + "Delft-Gray" "Delft-Green" "Delft-Mint" "Delft-Purple"
> + "Delft-Red" "Delft-Teal")))))
Interesting use of install-plan, but wouldn't it be to copy everything
and simply exclude the previous delete files? E.g. (untested):
#:install-plan
`(("." "./" #:exclude ("README.md" "LICENSE" "logo.jpg")))
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-02-27 10:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 16:32 [bug#39717] [PATCH 1/3] gnu: delft-icon-theme: Use the copy-build-system Leo Prikler
2020-02-21 16:32 ` [bug#39716] [PATCH 2/3] gnu: gnome-shell-extension-appindicator: " Leo Prikler
2020-02-27 10:31 ` Pierre Neidhardt
2020-02-21 16:32 ` [bug#39715] [PATCH 3/3] gnu: gnome-shell-extension-noannoyance: " Leo Prikler
2020-02-27 10:34 ` Pierre Neidhardt
2020-02-27 10:27 ` Pierre Neidhardt [this message]
2020-02-27 10:52 ` [bug#39717] [PATCH 1/3] gnu: delft-icon-theme: " Leo Prikler
2020-02-27 13:19 ` Pierre Neidhardt
2020-02-27 13:44 ` Leo Prikler
2020-02-27 14:02 ` Pierre Neidhardt
2020-02-27 14:49 ` Leo Prikler
2020-02-28 8:40 ` Pierre Neidhardt
2020-02-27 10:52 ` Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu9472ai.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=39717@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).