From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:37174)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jC1p9-0001QR-3r
 for guix-patches@gnu.org; Wed, 11 Mar 2020 09:55:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jC1p8-0005zD-39
 for guix-patches@gnu.org; Wed, 11 Mar 2020 09:55:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:47832)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jC1p7-0005yw-To
 for guix-patches@gnu.org; Wed, 11 Mar 2020 09:55:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jC1p7-0005Hg-T6
 for guix-patches@gnu.org; Wed, 11 Mar 2020 09:55:01 -0400
Subject: [bug#40016] [PATCH] inferior: Distinguish inferior exceptions.
Resent-Message-ID: <handler.40016.B40016.158393487620271@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20200310160305.15865-1-ludo@gnu.org> <878sk8t8vr.fsf@gnu.org>
 <8736afeoqu.fsf@cbaines.net>
Date: Wed, 11 Mar 2020 14:54:22 +0100
In-Reply-To: <8736afeoqu.fsf@cbaines.net> (Christopher Baines's message of
 "Wed, 11 Mar 2020 00:09:29 +0000")
Message-ID: <87mu8nj8tt.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 40016@debbugs.gnu.org

Hi!

Christopher Baines <mail@cbaines.net> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Ludovic Court=C3=A8s <ludo@gnu.org> skribis:
>>
>>> This avoids ambiguities when looking at a backtrace where the exception
>>> was actually thrown by an inferior in a very different context.
>>
>> The idea was suggested at the Guix Days by someone who had had a hard
>> time looking at one of these weird backtraces, until you realize the
>> exception was actually thrown by another process.
>>
>> There are a few places in the Data Service that do things like:
>>
>>   (catch 'misc-error
>>     (lambda ()
>>       (inferior-eval =E2=80=A6))
>>     =E2=80=A6)
>>
>> This will have to be adjusted.  Does that work for you, Chris?
>
> Yeah that sounds fine.

Good.

> Generally I think it's good to keep backwards compatibility with the
> Guix Data Service, so I'd be looking to support both ways exceptions
> can be raised, but that doesn't seem to difficult.

Yes.  Though you=E2=80=99ll also have to handle Guile 3.0 vs. 2.2 exception
types, in particular wrt. SRFI-34 exceptions (see Guix commit
7f3bbfaf8ec3b96e02e0cf74e7515ac33c002107.)

Thanks for your feedback,
Ludo=E2=80=99.