From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37232) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKwal-0007bz-A6 for guix-patches@gnu.org; Sun, 05 Apr 2020 00:09:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKwak-0006wJ-4T for guix-patches@gnu.org; Sun, 05 Apr 2020 00:09:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKwaj-0006vR-Vc for guix-patches@gnu.org; Sun, 05 Apr 2020 00:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKwaj-0000bl-R2 for guix-patches@gnu.org; Sun, 05 Apr 2020 00:09:01 -0400 Subject: [bug#40264] Linphone: 11-add-mediastreamer-v2 Resent-Message-ID: From: maxim.cournoyer@gmail.com References: <20200403133827.52d529cb@scratchpost.org> <981ea9c838575bacfe934a652ceeca62@disroot.org> Date: Sun, 05 Apr 2020 00:08:08 -0400 In-Reply-To: (Raghav Gururajan's message of "Fri, 03 Apr 2020 14:30:09 +0000") Message-ID: <87mu7q3787.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: Danny Milosavljevic , 40264@debbugs.gnu.org Hello Raghav, "Raghav Gururajan" writes: > Hi Danny! > >>> + (list >>> >>> + ;; For fixing definitions. >> >> Yes, but why? What would happen if we didn't do it? > > Otherwise, we get `-Werror` flag related compilation errors. Could you please clarify that in a comment above the patch? >>> + (origin >>> + (method url-fetch) >>> + (uri >>> + (string-append "https://gitlab.linphone.org/BC/public/mediastreamer2/commit" >>> + "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff")) >>> + (file-name "mediastreamer-msfactory.patch") >> >> I'm not sure what the outcome of the latest discussion on carrying patches was. >> Should we carry patches in Guix now or fetch them from external source? > > I think it's good as long as we use hash to verify. :-) The problem is that metadata or format of auto-generated patches may change on a whim. In past discussions it was decided best to not use them (that is, it's best to embed a copy of it in Guix sources) [0]. [0] https://lists.gnu.org/archive/html/guix-devel/2018-11/msg00554.html I'll post more comments in your original message. Maxim