From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 40684@debbugs.gnu.org
Subject: [bug#40684] [PATCH core-updates] guix: self: Use guile with libgc-7.
Date: Fri, 17 Apr 2020 23:02:47 +0200 [thread overview]
Message-ID: <87mu79akqw.fsf@gnu.org> (raw)
In-Reply-To: <20200417172142.23741-1-mail@cbaines.net> (Christopher Baines's message of "Fri, 17 Apr 2020 18:21:43 +0100")
Hi!
Christopher Baines <mail@cbaines.net> skribis:
> Rather than libgc version 8. This should avoid crashes that can occur,
> particularly when loading data in to the Guix Data Service [1].
>
> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40525
>
> * gnu/packages/guile.scm (guile-3.0/libgc-7): New variable.
> * guix/self.scm (specification->package): Use guile-3.0/libgc-7 for guile.
> ---
> gnu/packages/guile.scm | 12 ++++++++++++
> guix/self.scm | 2 +-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
> index 8ccbc22f26..6b7bd492ed 100644
> --- a/gnu/packages/guile.scm
> +++ b/gnu/packages/guile.scm
> @@ -309,6 +309,18 @@ without requiring the source code to be rewritten.")
>
> (define-public guile-next guile-3.0)
>
> +(define-public guile-3.0/libgc-7
> + (hidden-package
> + (package
> + (inherit guile-3.0)
> + (propagated-inputs
> + (map (lambda (input)
> + (if (string=? (car input)
> + "bdw-gc")
> + (list "bdw-gc" libgc-7)
> + input))
Nitpicking: please write it as:
`(("bdw-gc" ,libgc-7)
,@(alist-delete "bdw-gc" (package-propagated-inputs guile-3.0)))
as we do elsewhere.
Also, could you add a comment referencing the bug report, so we
immediately see why this variant exists?
OK with these changes, thanks!
Ludo’.
next prev parent reply other threads:[~2020-04-17 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 17:21 [bug#40684] [PATCH core-updates] guix: self: Use guile with libgc-7 Christopher Baines
2020-04-17 21:02 ` Ludovic Courtès [this message]
2020-04-18 8:10 ` Christopher Baines
2020-04-18 16:51 ` bug#40684: " Christopher Baines
2020-04-18 8:08 ` [bug#40684] [PATCH v2] " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu79akqw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40684@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).