unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Stefan <stefan-guix@vodafonemail.de>
Cc: 41163-done@debbugs.gnu.org
Subject: bug#41163: [PATCH] gnu: grub: Allow a PNG image and replace (aspect-ratio) with (resolution).
Date: Tue, 19 May 2020 09:36:16 +0200	[thread overview]
Message-ID: <87mu64tlzj.fsf@gnu.org> (raw)
In-Reply-To: <9EBB480D-957F-4A77-B01A-B8A8F39172D1@vodafonemail.de> (Stefan's message of "Sun, 17 May 2020 23:53:50 +0200")


Hello Stefan,

>  (define* (svg->png svg #:key width height)
> -  "Build a PNG of HEIGHT x WIDTH from SVG."
> +  "Build a PNG of HEIGHT x WIDTH from SVG if its file suffix is \".svg\".

I renamed this one "image->png" which is closer to what's happening I
think.

Tested your patch with both the default configuration and a custom PNG
image, it works fine.

Pushed as 9cdb10d5.

Bonus points if you come up with a documentation patch describing how to
setup a custom svg/png image :)

Thanks,

Mathieu




      parent reply	other threads:[~2020-05-19  7:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 22:44 [bug#41163] [PATCH] gnu: grub: Allow a PNG image and replace (aspect-ratio) with (resolution) Stefan
2020-05-10  7:07 ` Mathieu Othacehe
2020-05-10 15:43   ` Stefan
2020-05-17 21:53     ` Stefan
2020-05-17 22:03       ` Stefan
2020-05-19  7:36       ` Mathieu Othacehe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu64tlzj.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=41163-done@debbugs.gnu.org \
    --cc=stefan-guix@vodafonemail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).