From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qDQaMUK4y15TBwAA0tVLHw (envelope-from ) for ; Mon, 25 May 2020 12:21:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0Kf7LEK4y142aAAAB5/wlQ (envelope-from ) for ; Mon, 25 May 2020 12:21:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A35894036C for ; Mon, 25 May 2020 12:21:22 +0000 (UTC) Received: from localhost ([::1]:59724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdC6b-0000xr-FE for larch@yhetil.org; Mon, 25 May 2020 08:21:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdBbL-0004f0-J3 for guix-patches@gnu.org; Mon, 25 May 2020 07:49:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdBbL-0004vR-A3 for guix-patches@gnu.org; Mon, 25 May 2020 07:49:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdBbL-0005ng-83 for guix-patches@gnu.org; Mon, 25 May 2020 07:49:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41395] [PATCH 2/2] gnu: Add python-questionary Resent-From: Edouard Klein Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 May 2020 11:49:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41395 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 41395@debbugs.gnu.org Received: via spool by 41395-submit@debbugs.gnu.org id=B41395.159040728322207 (code B ref 41395); Mon, 25 May 2020 11:49:03 +0000 Received: (at 41395) by debbugs.gnu.org; 25 May 2020 11:48:03 +0000 Received: from localhost ([127.0.0.1]:40069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdBaM-0005m2-NJ for submit@debbugs.gnu.org; Mon, 25 May 2020 07:48:03 -0400 Received: from sender4-op-o11.zoho.com ([136.143.188.11]:17124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdBCO-000315-Mw for 41395@debbugs.gnu.org; Mon, 25 May 2020 07:23:17 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1590405794; cv=none; d=zohomail.com; s=zohoarc; b=gKap0pB1KgWYTyynQ+cJRtkuF8wX4ELLBxqm4Qah795GiWtn6VK+3JTwhrumXLhhPHkpBzWtQ6xmQaviisosQ4sHepxnztvM9q92TV/mtAeWkW98LEZkj9UlW6MzPeNYc7CTz2HY/ppIoAWbROlf0Uwe3yed7dqns9DyfyZq7hc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590405794; h=Content-Type:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DX12dUlgDBnfSjBzt4QONBU+kesXN393LLtmnxdlVAI=; b=EQZJYyEFfrt7VaDtTU2+GfNKU/HeFZPzEDWoZJUuE2WQJEu17yQDv6so+jd1cUhO4R/WMIFZl0FELs4XdGizEhhXyX2HRChXMjWpE5YLaEOm8JzxZD3fLs+6mnnV4cLfZZhT0D9rkyNOaa4HChaTvHhG3ZPunvd1DTlq/DbOFs4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rdklein.fr; spf=pass smtp.mailfrom=edou@rdklein.fr; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1590405794; s=zoho; d=rdklein.fr; i=edou@rdklein.fr; h=References:From:To:Subject:In-reply-to:Message-ID:Date:MIME-Version:Content-Type; bh=DX12dUlgDBnfSjBzt4QONBU+kesXN393LLtmnxdlVAI=; b=IAakH5toB/bt27hDj7JcX5VVmX4+Bk1w4K8/Dvz/fF9LRats7EznN/Kld5ZWrZmI hrUZCzo8ZwCc7B+ST7knC//ebuMv7KToMlXB8zAPelmK2ErTxLXLtD9kzH937C+iqwO ie14nR9laqUZ0ZNTatwvFvLGHBEePdoIg0gExPaU= Received: from alice.lan (lfbn-idf1-1-1299-119.w90-79.abo.wanadoo.fr [90.79.23.119]) by mx.zohomail.com with SMTPS id 1590405792381988.8581724519922; Mon, 25 May 2020 04:23:12 -0700 (PDT) References: <87v9ksckt3.fsf@alice.lan> <87pnb0ckjh.fsf@alice.lan> <87tv067ay2.fsf@devup.no> User-agent: mu4e 1.4.6; emacs 26.3 From: Edouard Klein In-reply-to: <87tv067ay2.fsf@devup.no> Message-ID: <87mu5wi7hn.fsf@alice.lan> Date: Mon, 25 May 2020 13:23:00 +0200 MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Mon, 25 May 2020 07:48:00 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-Mailman-Approved-At: Mon, 25 May 2020 08:20:55 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=rdklein.fr header.s=zoho header.b=IAakH5to; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.99 X-TUID: yH4pMqd4tBws Marius Bakke writes: > Edouard Klein writes: > >> * /gnu/packages/python-xyz.scm (python-questionary): New variable >> * /gnu/packages/python-check.scm (python-pytest-pycodestyle): New variable > > Can you submit these packages as two separate patches? > > [...] > Done >> +(define-public python-pytest-pycodestyle >> + (package >> + (name "python-pytest-pycodestyle") >> + (version "2.0.0") ;; Any version higher than that requires python-pytest~=5.4 >> + ;; (python-pytest is at version 5.3.5 as I write this comment >> + ;; and 5478 packages depend on it.) > > You can create a 'python-pytest-5.4' variable instead of sticking to > this old version, we'll probably need it sooner or later. No strong > opinion though. > I did not understand that pinning dependencies was also allowed for future versions. I tried but I can't get python-pytest 5.4's tests to pass, so I'll leave it like that for now and try to come back and revisit that if I have some time. > [...] > >> +(define-public python-questionary >> + (package >> + (name "python-questionary") >> + (version "1.5.2") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "questionary" version)) >> + (sha256 >> + (base32 >> + "09n737qmvzbibl8hmbd5zfg1502fd9n0r8qjzz1y0vy8nqv1xr7n")))) >> + (build-system python-build-system) >> + (propagated-inputs >> + `(("python-prompt-toolkit" ,python-prompt-toolkit))) >> + (native-inputs >> + `(("python-coveralls" ,python-coveralls) >> + ("python-pytest-cov" ,python-pytest-cov) >> + ("python-pytest-pycodestyle" >> + ,python-pytest-pycodestyle) >> + )) > > These parens feel lonely. :-) I did a last minute edit and forgot to lint again, sorry :) > >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (replace 'check >> + (lambda _ >> + (invoke "py.test")))))) >> + (home-page "https://github.com/tmbo/questionary") >> + (synopsis >> + "Pretty command line user prompts") > > The line break here is not necessary. > > LGTM with these changes, can you send updated patches? > > Thanks! Thank you for reviewing the changes and for the suggestions :)