unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Edouard Klein <edou@rdklein.fr>
To: 41395@debbugs.gnu.org
Subject: [bug#41395] [PATCH 2/2] gnu: Add python-questionary
Date: Mon, 25 May 2020 13:23:00 +0200	[thread overview]
Message-ID: <87mu5wi7hn.fsf@alice.lan> (raw)
In-Reply-To: <87tv067ay2.fsf@devup.no>


Marius Bakke writes:

> Edouard Klein <edk@beaver-labs.com> writes:
>
>> * /gnu/packages/python-xyz.scm (python-questionary): New variable
>> * /gnu/packages/python-check.scm (python-pytest-pycodestyle): New variable
>
> Can you submit these packages as two separate patches?
>
> [...]
>
Done

>> +(define-public python-pytest-pycodestyle
>> +  (package
>> +    (name "python-pytest-pycodestyle")
>> +    (version "2.0.0")  ;; Any version higher than that requires python-pytest~=5.4
>> +    ;; (python-pytest is at version 5.3.5 as I write this comment
>> +    ;; and 5478 packages depend on it.)
>
> You can create a 'python-pytest-5.4' variable instead of sticking to
> this old version, we'll probably need it sooner or later.  No strong
> opinion though.
>

I did not understand that pinning dependencies was also allowed for
future versions. I tried but I can't get python-pytest 5.4's tests to
pass, so I'll leave it like that for now and try to come back and
revisit that if I have some time.

> [...]
>
>> +(define-public python-questionary
>> +  (package
>> +   (name "python-questionary")
>> +   (version "1.5.2")
>> +   (source
>> +    (origin
>> +     (method url-fetch)
>> +     (uri (pypi-uri "questionary" version))
>> +     (sha256
>> +      (base32
>> +       "09n737qmvzbibl8hmbd5zfg1502fd9n0r8qjzz1y0vy8nqv1xr7n"))))
>> +   (build-system python-build-system)
>> +   (propagated-inputs
>> +    `(("python-prompt-toolkit" ,python-prompt-toolkit)))
>> +   (native-inputs
>> +    `(("python-coveralls" ,python-coveralls)
>> +      ("python-pytest-cov" ,python-pytest-cov)
>> +      ("python-pytest-pycodestyle"
>> +       ,python-pytest-pycodestyle)
>> +      ))
>
> These parens feel lonely.  :-)

I did a last minute edit and forgot to lint again, sorry :)

>
>> +   (arguments
>> +    `(#:phases
>> +      (modify-phases %standard-phases
>> +        (replace 'check
>> +          (lambda _
>> +            (invoke "py.test"))))))
>> +   (home-page "https://github.com/tmbo/questionary")
>> +   (synopsis
>> +    "Pretty command line user prompts")
>
> The line break here is not necessary.
>
> LGTM with these changes, can you send updated patches?
>
> Thanks!

Thank you for reviewing the changes and for the suggestions :)




  reply	other threads:[~2020-05-25 12:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  9:53 [bug#41395] [PATCH 0/2] gnu: Add python-questionary Edouard Klein
2020-05-19  9:58 ` [bug#41395] [PATCH 1/2] gnu: python-prompt-toolkit: Update to 3.0.5 Edouard Klein
2020-05-23 18:35   ` Marius Bakke
2020-05-25 10:52     ` Edouard Klein
2020-05-25 22:21       ` Marius Bakke
2020-05-26  9:28         ` Edouard Klein
2020-05-19  9:59 ` [bug#41395] [PATCH 2/2] gnu: Add python-questionary Edouard Klein
2020-05-23 18:39   ` Marius Bakke
2020-05-25 11:23     ` Edouard Klein [this message]
2020-05-25 11:24 ` [bug#41395] [PATCH 1/4] gnu: Update python-iml homepage to https Edouard Klein
2020-05-25 22:23   ` Marius Bakke
2020-05-25 11:26 ` [bug#41395] [PATCH 2/4] gnu: Update python-prompt-toolkit to version 3.0.5 Edouard Klein
2020-05-25 22:28   ` Marius Bakke
2020-05-26 11:39     ` Edouard Klein
2020-05-25 11:27 ` [bug#41395] [PATCH 3/4] gnu: Add python-pytest-pycodestyle Edouard Klein
2020-05-25 22:33   ` Marius Bakke
2020-05-25 11:28 ` [bug#41395] [PATCH 4/4] gnu: Add python-questionary Edouard Klein
2020-05-26  9:30 ` [bug#41395] [PATCH 1/3] gnu: Update python-widgetsnbextension to 3.5.1 Edouard Klein
2020-05-30 13:16   ` Marius Bakke
2020-05-26  9:31 ` [bug#41395] [PATCH 2/3] gnu: Update python-ipywidgets to 7.5.1 Edouard Klein
2020-05-30 13:18   ` Marius Bakke
2020-05-26  9:33 ` [bug#41395] [PATCH 3/3] gnu: Update python-jupyter-console to 6.1.0 Edouard Klein
2020-05-30 13:19   ` Marius Bakke
2020-05-26 11:21 ` [bug#41395] [PATCH] gnu: Move nose from propagated to native in python-iml Edouard Klein
2020-05-30 13:21   ` Marius Bakke
2020-05-26 11:40 ` [bug#41395] [PATCH 1/3] " Edouard Klein
2020-05-26 11:41 ` [bug#41395] [PATCH 2/3] gnu: Remove python-prompt-toolkit-1 Edouard Klein
2020-05-26 13:41   ` Edouard Klein
2020-05-30 13:27     ` Marius Bakke
2020-05-30 13:26   ` Marius Bakke
2020-05-26 11:42 ` [bug#41395] [PATCH 3/3] gnu: Update python-prompt-toolkit to version 3.0.5 Edouard Klein
2020-05-26 13:55   ` Edouard Klein
2020-05-26 13:53 ` [bug#41395] [PATCH] " Edouard Klein
2020-05-30 13:48   ` bug#41395: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu5wi7hn.fsf@alice.lan \
    --to=edou@rdklein.fr \
    --cc=41395@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).