From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id INmdHXSO5l7uLwAA0tVLHw (envelope-from ) for ; Sun, 14 Jun 2020 20:54:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id xRF3GXSO5l4meAAAbx9fmQ (envelope-from ) for ; Sun, 14 Jun 2020 20:54:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F1091940418 for ; Sun, 14 Jun 2020 20:54:11 +0000 (UTC) Received: from localhost ([::1]:33464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkZdq-0006yM-UD for larch@yhetil.org; Sun, 14 Jun 2020 16:54:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkZdi-0006wY-V1 for guix-patches@gnu.org; Sun, 14 Jun 2020 16:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkZdi-0002de-JE for guix-patches@gnu.org; Sun, 14 Jun 2020 16:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkZdi-0000d7-Fz for guix-patches@gnu.org; Sun, 14 Jun 2020 16:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41573] [PATCH Shepherd] shepherd: service: Add #:supplementary-groups. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 14 Jun 2020 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41573 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 41573@debbugs.gnu.org Received: via spool by 41573-submit@debbugs.gnu.org id=B41573.15921680032368 (code B ref 41573); Sun, 14 Jun 2020 20:54:02 +0000 Received: (at 41573) by debbugs.gnu.org; 14 Jun 2020 20:53:23 +0000 Received: from localhost ([127.0.0.1]:44600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkZd5-0000c8-Ar for submit@debbugs.gnu.org; Sun, 14 Jun 2020 16:53:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkZd3-0000bv-WB for 41573@debbugs.gnu.org; Sun, 14 Jun 2020 16:53:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52888) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkZcy-0002Wg-Lc; Sun, 14 Jun 2020 16:53:16 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43792 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkZcx-0000PC-T6; Sun, 14 Jun 2020 16:53:16 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87a71sbpr4.fsf@gmail.com> Date: Sun, 14 Jun 2020 22:53:14 +0200 In-Reply-To: <87a71sbpr4.fsf@gmail.com> (Oleg Pykhalov's message of "Thu, 28 May 2020 08:19:27 +0300") Message-ID: <87mu55s72d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: PwZlqn6Fmkzx Hello, Oleg Pykhalov skribis: > From 5718eb5f4130530b48df896d7f7e4a126e08428a Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Sun, 24 May 2020 20:30:27 +0300 > Subject: [PATCH] service: Add #:supplementary-groups. > > * modules/shepherd/service.scm (format-supplementary-groups): New procedu= re. > (exec-command, fork+exec-command, make-forkexec-constructor): Add > '#:supplementary-groups'. > * doc/shepherd.texi (Service De- and Constructors): Document this. [...] > +(define (format-supplementary-groups supplementary-groups) > + (if (vector? supplementary-groups) > + supplementary-groups > + (list->vector (map (lambda (group) (group:gid (getgr group))) > + supplementary-groups)))) Perhaps we should remove the =E2=80=98vector?=E2=80=99 case, no? I find it= clearer when the interface accepts just one single data type. Apart from that, it LGTM! Note that for compatibility reasons we=E2=80=99ll have to wait before using= it in Guix System. Thanks, Ludo=E2=80=99.