From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SHRZOp9T5l7LcQAA0tVLHw (envelope-from ) for ; Sun, 14 Jun 2020 16:43:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SOQLNp9T5l7+RAAAbx9fmQ (envelope-from ) for ; Sun, 14 Jun 2020 16:43:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6ED759400B1 for ; Sun, 14 Jun 2020 16:43:11 +0000 (UTC) Received: from localhost ([::1]:46370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkViu-0002tQ-Pg for larch@yhetil.org; Sun, 14 Jun 2020 12:43:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkVio-0002sd-Iv for guix-patches@gnu.org; Sun, 14 Jun 2020 12:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32851) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkVio-0000JL-AB for guix-patches@gnu.org; Sun, 14 Jun 2020 12:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkVio-0002r1-9J for guix-patches@gnu.org; Sun, 14 Jun 2020 12:43:02 -0400 Subject: bug#41785: [PATCH v4] services: Add 'hurd-in-vm service-type'. Resent-From: Jan Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 14 Jun 2020 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41785 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 41785-done@debbugs.gnu.org Mail-Followup-To: 41785@debbugs.gnu.org, janneke@gnu.org, janneke@gnu.org Received: via spool by 41785-done@debbugs.gnu.org id=D41785.159215294910924 (code D ref 41785); Sun, 14 Jun 2020 16:43:02 +0000 Received: (at 41785-done) by debbugs.gnu.org; 14 Jun 2020 16:42:29 +0000 Received: from localhost ([127.0.0.1]:44396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkViG-0002q8-Qf for submit@debbugs.gnu.org; Sun, 14 Jun 2020 12:42:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkViF-0002pv-F9 for 41785-done@debbugs.gnu.org; Sun, 14 Jun 2020 12:42:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48509) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkVi9-000091-Rr; Sun, 14 Jun 2020 12:42:21 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=48132 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkVi1-00081Q-Q8; Sun, 14 Jun 2020 12:42:20 -0400 From: Jan Nieuwenhuizen Organization: AvatarAcademy.nl References: <20200610085441.890-1-janneke@gnu.org> <87eeql9xvt.fsf@gnu.org> <87wo4d2rm5.fsf@gnu.org> <873670l3z9.fsf@gnu.org> <87eeqknf4d.fsf@gnu.org> <878sgpg856.fsf_-_@gnu.org> <87eeqhkea1.fsf@gnu.org> <87o8pleqg5.fsf@gnu.org> <875zbtk5l8.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Sun, 14 Jun 2020 18:42:10 +0200 In-Reply-To: <875zbtk5l8.fsf@gnu.org> (Mathieu Othacehe's message of "Sun, 14 Jun 2020 17:52:19 +0200") Message-ID: <87mu558uql.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: qi9XxllsTC0c Mathieu Othacehe writes: >> (define (hurd-multiboot-modules os) >> ... >> (libc (if target >> (with-parameters ((%current-target-system #f)) >> ;; TODO: cross-libc has extra patches for the Hurd; >> ;; remove in next rebuild cycle >> (cross-libc target)) >> glibc)) >> >> we take the ELSE branch here -- and that does not work. AIUI, this is >> really a temporary kludge until the next rebuild cycle we can move some >> hurd-specific glibc patches from cross-libc to glibc-proper. > > Oh, I know why! In "system-image", there are a few calls, in the first > let, that are outside the "with-parameters", in particular "bootcfg" > which triggers the problem you are describing above. Ah, yes that makes sense. > Maybe something as naive as: > > diff --git a/gnu/system/image.scm b/gnu/system/image.scm [..] > - (let* ((os (operating-system-for-image image)) [..] > - (with-parameters ((%current-target-system target)) > + (with-parameters ((%current-target-system target)) > + (let* ((os (operating-system-for-image image)) > > would do the trick. It does! > I went ahead and pushed a variant of this as > c9f6e2e5bdff186583bdc360832b57f4c56e3427. Woohoo! I remove the with-parameters in hurd-vm-disk-image and pushed to master 5e9cf93364d87c70f8bfad915417cd75d21c0fed Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com