From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CLS5FuxbFV9yeQAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 08:55:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UI2XEuxbFV8sHAAAB5/wlQ (envelope-from ) for ; Mon, 20 Jul 2020 08:55:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE4F19403C6 for ; Mon, 20 Jul 2020 08:55:07 +0000 (UTC) Received: from localhost ([::1]:40842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxRZh-0006Ng-4J for larch@yhetil.org; Mon, 20 Jul 2020 04:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxRZd-0006NU-V9 for guix-patches@gnu.org; Mon, 20 Jul 2020 04:55:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50393) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxRZd-0006EA-KA for guix-patches@gnu.org; Mon, 20 Jul 2020 04:55:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxRZd-00026D-It for guix-patches@gnu.org; Mon, 20 Jul 2020 04:55:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42404] [PATCH] gnu: Add libtmcg and dkgpg. Resent-From: Justus Winter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Jul 2020 08:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42404 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brett Gilio Cc: 42404@debbugs.gnu.org Received: via spool by 42404-submit@debbugs.gnu.org id=B42404.15952352437996 (code B ref 42404); Mon, 20 Jul 2020 08:55:01 +0000 Received: (at 42404) by debbugs.gnu.org; 20 Jul 2020 08:54:03 +0000 Received: from localhost ([127.0.0.1]:33706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxRYh-00024u-GW for submit@debbugs.gnu.org; Mon, 20 Jul 2020 04:54:03 -0400 Received: from avior.uberspace.de ([185.26.156.32]:51730 ident=Aje1HCzPRt3) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxRYd-00024S-Gp for 42404@debbugs.gnu.org; Mon, 20 Jul 2020 04:54:02 -0400 Received: (qmail 9541 invoked from network); 20 Jul 2020 08:53:57 -0000 Received: from localhost (HELO europa) (127.0.0.1) by avior.uberspace.de with SMTP; 20 Jul 2020 08:53:57 -0000 Received: from localhost ([127.0.0.1]) by europa with esmtp (Exim 4.92) (envelope-from ) id 1jxRYZ-00019p-Er; Mon, 20 Jul 2020 10:53:55 +0200 From: Justus Winter In-Reply-To: <87y2nfp5c6.fsf@gnu.org> References: <20200717093609.9507-1-justus@sequoia-pgp.org> <87y2nfp5c6.fsf@gnu.org> Date: Mon, 20 Jul 2020 10:53:55 +0200 Message-ID: <87mu3ufty4.fsf@europa.jade-hamburg.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: QsXarafVgIxs --=-=-= Content-Type: text/plain Brett Gilio writes: > Thank you for taking time to contribute these packages. Overall, without > trying them and running the linter they seem okay. However, a few notes: > > 1. Does this require a new file? Well, there is no good place to put OpenPGP software. There is gnupg.scm, which contains GnuPG-related packages, and some other OpenPGP software, that IMHO shouldn't be in gnupg.scm. GnuPG is an implementation of the OpenPGP protocol. Putting a different implementation into gnupg.scm just because it implements the same protocol seems wrong. > If yes, please make sure that new file gets referenced appropriately > in our Makefile so that it gets included in our bytecode compilation. Sure, I missed that. > 2. Could you split this into two patches? One introducing the new file > and a first package. And a second patch introducing the second > package? Sure. Justus --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJWpOVeSnLZetJGjniNx+MzhfeR0FAl8VW6MACgkQiNx+Mzhf eR0aaggApjCU6yYrVICF+AwTl8sTKlUapGAf9U3Xnc/lPhydOdnTZQXROx8JMcDx aHUITP8/VnqG9DTlLdtKwO8OehOrzXA4lGzvXoOz0vRq/ezZYEtsZ+MSteAFIN8e KON9cCEbqMWsJyTkC7BqkG4STrrNIfkJYjcOkMkmbIFAyUAAYj4sX6XSrNDTrL9q BLSaZlsz4J3yv1goWN8BtGOPgKO7ggII1YPFEFrhoEDkHmFYpeSs6ZPnQSmbGChA mMAn0wBY3NASsPnXcLbgL+xF2DXdYYcAUSVLu/NUOU8+zy6dpi12QQCShTCqCDJk 7MdSZWj/vvdMuY4Na3ZYy55y7KG7Hg== =s5FY -----END PGP SIGNATURE----- --=-=-=--