From: Justus Winter <justus@sequoia-pgp.org>
To: Brett Gilio <brettg@gnu.org>
Cc: 42404@debbugs.gnu.org
Subject: [bug#42404] [PATCH] gnu: Add libtmcg and dkgpg.
Date: Mon, 20 Jul 2020 10:53:55 +0200 [thread overview]
Message-ID: <87mu3ufty4.fsf@europa.jade-hamburg.de> (raw)
In-Reply-To: <87y2nfp5c6.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
Brett Gilio <brettg@gnu.org> writes:
> Thank you for taking time to contribute these packages. Overall, without
> trying them and running the linter they seem okay. However, a few notes:
>
> 1. Does this require a new file?
Well, there is no good place to put OpenPGP software. There is
gnupg.scm, which contains GnuPG-related packages, and some other OpenPGP
software, that IMHO shouldn't be in gnupg.scm. GnuPG is an
implementation of the OpenPGP protocol. Putting a different
implementation into gnupg.scm just because it implements the same
protocol seems wrong.
> If yes, please make sure that new file gets referenced appropriately
> in our Makefile so that it gets included in our bytecode compilation.
Sure, I missed that.
> 2. Could you split this into two patches? One introducing the new file
> and a first package. And a second patch introducing the second
> package?
Sure.
Justus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-07-20 8:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 9:36 [bug#42404] [PATCH] gnu: Add libtmcg and dkgpg Justus Winter
[not found] ` <87y2nfp5c6.fsf@gnu.org>
2020-07-20 8:53 ` Justus Winter [this message]
2020-07-20 9:28 ` [bug#42404] [PATCH 1/2] gnu: Add libtmcg Justus Winter
2020-07-20 9:28 ` [bug#42404] [PATCH 2/2] gnu: Add dkgpg Justus Winter
2020-07-23 12:03 ` [bug#42404] [PATCH 1/5] gnu: Add libtmcg Justus Winter
2020-07-23 12:03 ` [bug#42404] [PATCH 2/5] gnu: Add dkgpg Justus Winter
2020-07-23 12:03 ` [bug#42404] [PATCH 3/5] gnu: Add rnp Justus Winter
2020-07-24 10:27 ` Ludovic Courtès
2020-07-24 11:18 ` Justus Winter
2020-07-24 12:43 ` Justus Winter
2020-07-24 13:20 ` Ludovic Courtès
2020-07-27 13:38 ` [bug#42404] [PATCH 1/3] " Justus Winter
2020-07-27 13:44 ` Justus Winter
2020-07-28 22:16 ` Ludovic Courtès
2020-07-23 12:03 ` [bug#42404] [PATCH 4/5] gnu: Add python-pgpy Justus Winter
2020-07-23 12:03 ` [bug#42404] [PATCH 5/5] gnu: Add python-sop Justus Winter
2020-07-28 22:19 ` bug#42404: " Ludovic Courtès
2020-07-24 12:21 ` [bug#42404] [PATCH 1/5] gnu: Add libtmcg Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu3ufty4.fsf@europa.jade-hamburg.de \
--to=justus@sequoia-pgp.org \
--cc=42404@debbugs.gnu.org \
--cc=brettg@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).