From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SPESMadDKl/aegAA0tVLHw (envelope-from ) for ; Wed, 05 Aug 2020 05:29:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6AvBLKdDKl8JUAAAbx9fmQ (envelope-from ) for ; Wed, 05 Aug 2020 05:29:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1497C9403C9 for ; Wed, 5 Aug 2020 05:29:11 +0000 (UTC) Received: from localhost ([::1]:48416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3BzB-00064L-1A for larch@yhetil.org; Wed, 05 Aug 2020 01:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3Bz4-000649-Ly for guix-patches@gnu.org; Wed, 05 Aug 2020 01:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38013) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3Bz4-0001R5-B0 for guix-patches@gnu.org; Wed, 05 Aug 2020 01:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3Bz4-0003NL-56 for guix-patches@gnu.org; Wed, 05 Aug 2020 01:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42689] another try Resent-From: Alexandru-Sergiu Marton Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Aug 2020 05:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42689 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Brett Gilio Cc: 42689@debbugs.gnu.org, Adam Kandur Received: via spool by 42689-submit@debbugs.gnu.org id=B42689.159660532712953 (code B ref 42689); Wed, 05 Aug 2020 05:29:02 +0000 Received: (at 42689) by debbugs.gnu.org; 5 Aug 2020 05:28:47 +0000 Received: from localhost ([127.0.0.1]:49559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3Byp-0003Mr-9i for submit@debbugs.gnu.org; Wed, 05 Aug 2020 01:28:47 -0400 Received: from mout02.posteo.de ([185.67.36.66]:57095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3Byn-0003Me-Bn for 42689@debbugs.gnu.org; Wed, 05 Aug 2020 01:28:46 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id A3A412400FC for <42689@debbugs.gnu.org>; Wed, 5 Aug 2020 07:28:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.ro; s=2017; t=1596605319; bh=62uHGpBaAHUTf74ehprkHMk2o5r6UZX60WxyPnowHzU=; h=From:To:Cc:Subject:Date:From; b=qfp315ypRa1UKfeYd4xBrp0kOZUUpGOw06CKwFC8vBpRfcO96noAv+xDC1ErExbEH nbGM39aVvRR6Ja82Q1IjnpFB7/yuvns2z1C5FEHa0b1j+o/mqm2VVm+HR87HACvA0o bynJk8DW+ZHvJGbovhzflhFH7ymOZOD4vhWlara0tcCA2R+/TEenEn0mUWRRLmQIgY qIMq433zJCrFOzkqJKi9CaOvkHhX7BMSkrM9sKz3Q8GxfkvQH+snruNA0cuXwWOTbH 1nfyQeXmvRVyrxsn86ffm0TT2aENcm1Dj3OVAB35ZL7UrVrNhny8CFjCJV6fkzBLmn Xnr0IlO9+1UrA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BM0XQ68hkz9rxP; Wed, 5 Aug 2020 07:28:38 +0200 (CEST) From: Alexandru-Sergiu Marton References: <873651swhv.fsf@gnu.org> Date: Wed, 05 Aug 2020 08:28:39 +0300 In-Reply-To: <873651swhv.fsf@gnu.org> (Brett Gilio's message of "Tue, 04 Aug 2020 20:38:04 -0500") Message-ID: <87mu39ek54.fsf@posteo.ro> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.ro header.s=2017 header.b=qfp315yp; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.ro (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: X63KjrUiPWrg Hello Adam and Brett, Brett Gilio writes: > Adam Kandur writes: > >>>>>From 5cade1fff3fb64892321505edd9ac1b13420782e Mon Sep 17 00:00:00 2001 >> From: Adam Kandur >> Date: Tue, 4 Aug 2020 17:40:50 +0300 >> Subject: [PATCH] add sbcl-livesupport in gnu/packages/lisp-xyz.scm >> >> --- >> =C2=A0gnu/packages/lisp-xyz.scm | 29 +++++++++++++++++++++++++++++ >> =C2=A01 file changed, 29 insertions(+) >> > > Hi Adam, > > I am sorry to be a pest, but the commit message is still not following > our snippet protocol. I was trying to apply your patch, and take care of > it for you so that you could see what our expectation is more clearly > but your patch is mangled. Adam, I'm a fellow contributor, like you, and I'd like to share some of what I learned when sending patches to Guix. Brett says that your patch is mangled -- that usually happens at sending, depending on your email client. If you create your patches with `git format-patch`, I wouldn't trust an email client to keep the text intact by just pasting in the body of the mail. I would, instead, attach the patch file. You could, instead of manually putting the patch in a mail yourself, send it with `git send-email`. There is a great guide regarding how to do this: https://git-send-email.io/ . This is what I use to send patches to GNU Guix. As for the commit message itself, besides the snippet solution Brett suggested (maybe you're not using Emacs), there's always grepping the git log. I run `git log` in the guix source directory and search (using the '/' key) for whatever my patch does: if I'm adding a package, I search for "Add", for example. Here's what a commit that adds a new package usually looks like: --8<---------------cut here---------------start------------->8--- commit 28cbf3ef42353a491028d405a66595d45f3c8998 gnu: Add python-pgpy. * gnu/packages/python-crypto.scm (python-pgpy): New variable. --8<---------------cut here---------------end--------------->8--- Most of the time when adding a new package you follow this template. Replace the package name and file with whatever you have and you should be all set. (The "commit 28..." is just to show you what commit is this taken from. You must care only about what follows after it.) To format the commit message nicely, I recommend that you don't use the -m/--message flag, but let git open your $EDITOR so you can easily write multiple lines, like in the example above. If you want to change the message of your last commit, you can use git commit --amend. If you want to read more about the ChangeLog format, I believe this is the right place to look: https://www.gnu.org/prep/standards/html_node/Change-Logs.html . Myself, I never read that, but I always looks through the git log to see how others formatted messages for similar commits before. Cheers, Sergiu