From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eEXaMA1wYl91ewAA0tVLHw (envelope-from ) for ; Wed, 16 Sep 2020 20:05:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mLuYLA1wYl+NYgAAbx9fmQ (envelope-from ) for ; Wed, 16 Sep 2020 20:05:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 47FF294060B for ; Wed, 16 Sep 2020 20:05:33 +0000 (UTC) Received: from localhost ([::1]:54522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIdgK-0006nj-2J for larch@yhetil.org; Wed, 16 Sep 2020 16:05:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIdfq-0006Pu-Bd for guix-patches@gnu.org; Wed, 16 Sep 2020 16:05:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIdfq-0005Qi-0W for guix-patches@gnu.org; Wed, 16 Sep 2020 16:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIdfp-0002OT-RX for guix-patches@gnu.org; Wed, 16 Sep 2020 16:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43320] Add emacs-html-to-hiccup package Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Sep 2020 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Jesse Dowell Cc: 43320@debbugs.gnu.org Received: via spool by 43320-submit@debbugs.gnu.org id=B43320.16002866909172 (code B ref 43320); Wed, 16 Sep 2020 20:05:01 +0000 Received: (at 43320) by debbugs.gnu.org; 16 Sep 2020 20:04:50 +0000 Received: from localhost ([127.0.0.1]:36519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIdfd-0002Ns-Va for submit@debbugs.gnu.org; Wed, 16 Sep 2020 16:04:50 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:35849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIdfb-0002Nb-BO for 43320@debbugs.gnu.org; Wed, 16 Sep 2020 16:04:49 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 35C341C0005; Wed, 16 Sep 2020 20:04:39 +0000 (UTC) From: Nicolas Goaziou References: Date: Wed, 16 Sep 2020 22:04:34 +0200 In-Reply-To: (Jesse Dowell's message of "Thu, 10 Sep 2020 16:43:18 -0400") Message-ID: <87mu1p1oa5.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Y8UuX1+nIc5G Hello, Jesse Dowell writes: > I'm hoping the following patch can be useful for others. It's a package for > emacs-html-to-hiccup which can be very handy when working with clojure > programs that use hiccup syntax. Thank you. Could you send the patch with "git format-patch" or "git send-email" ? > > --8<---------------cut here---------------start------------->8--- > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index ff043463cc..253e51a79c 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -24550,4 +24550,29 @@ publically-accessible HTTP server.") > label references and citations in LaTeX. It is based on RefTeX, which is > included with Emacs.") > (license license:gpl3+))) > + > +(define-public emacs-html-to-hiccup > + (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1") > + (revision "0")) Could you add a comment explaining why we provide a non-released version (here because there is no release anyway). > + (package > + (name "emacs-html-to-hiccup") > + (version (git-version "20190909" revision commit)) It should be version "1.0" according to keyword in main file. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/plexus/html-to-hiccup") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp")))) Could you move the string on the line above ? > + (build-system emacs-build-system) > + (propagated-inputs > + `(("dash" ,emacs-dash) > + ("s" ,emacs-s))) There is an indentation issue here. > + (home-page "https://github.com/plexus/html-to-hiccup") > + (synopsis "Emacs package that turns HTML into Hiccup syntax") It could be "Turn HTML into Hiccup syntax" > + (description > + "Emacs package that turns HTML into Hiccup syntax, a notation > popular > +when doing Clojure/ClojureScript web development.") The description should be comprised of full sentences. Calling "guix lint" on your definition should report it. Here, it could be: This Emacs package turns HTML... > + (license license:mpl2.0)))) LICENSE file is mpl2.0, but the Elisp library has GPL3+ headers. Maybe you should add a comment about it. Could you send an updated patch? Regards, -- Nicolas Goaziou