unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jesse Dowell <jesse.dowell@gmail.com>
Cc: 43320@debbugs.gnu.org
Subject: [bug#43320] Add emacs-html-to-hiccup package
Date: Wed, 16 Sep 2020 22:04:34 +0200
Message-ID: <87mu1p1oa5.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CADdvwM-ggcxC-j4nhE+ROXRY1oapXSP4_SV9k_45qKV3e5nGLA@mail.gmail.com> (Jesse Dowell's message of "Thu, 10 Sep 2020 16:43:18 -0400")

Hello,

Jesse Dowell <jesse.dowell@gmail.com> writes:

> I'm hoping the following patch can be useful for others. It's a package for
> emacs-html-to-hiccup which can be very handy when working with clojure
> programs that use hiccup syntax.

Thank you.

Could you send the patch with "git format-patch" or "git send-email" ?
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ff043463cc..253e51a79c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -24550,4 +24550,29 @@ publically-accessible HTTP server.")
>  label references and citations in LaTeX.  It is based on RefTeX, which is
>  included with Emacs.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-html-to-hiccup
> +  (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1")
> +        (revision "0"))

Could you add a comment explaining why we provide a non-released version
(here because there is no release anyway).
> +    (package
> +      (name "emacs-html-to-hiccup")
> +      (version (git-version "20190909" revision commit))

It should be version "1.0" according to keyword in main file.
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/plexus/html-to-hiccup")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp"))))

Could you move the string on the line above ?

> +      (build-system emacs-build-system)
> +      (propagated-inputs
> +     `(("dash" ,emacs-dash)
> +       ("s" ,emacs-s)))

There is an indentation issue here.

> +      (home-page "https://github.com/plexus/html-to-hiccup")
> +      (synopsis "Emacs package that turns HTML into Hiccup syntax")

It could be

  "Turn HTML into Hiccup syntax"

> +      (description
> +       "Emacs package that turns HTML into Hiccup syntax, a notation
> popular
> +when doing Clojure/ClojureScript web development.")

The description should be comprised of full sentences. Calling "guix
lint" on your definition should report it. Here, it could be:

   This Emacs package turns HTML...

> +      (license license:mpl2.0))))

LICENSE file is mpl2.0, but the Elisp library has GPL3+ headers. Maybe
you should add a comment about it.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2020-09-16 20:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 20:43 Jesse Dowell
2020-09-16 20:04 ` Nicolas Goaziou [this message]
2020-09-19 15:03   ` Jesse Dowell
2020-09-22  9:48     ` bug#43320: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu1p1oa5.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=43320@debbugs.gnu.org \
    --cc=jesse.dowell@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git