unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#43860] [PATCH] gnu: python: Disable failing tests for the Hurd.
@ 2020-10-08  6:26 Jan Nieuwenhuizen
  2020-10-13 20:51 ` Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Nieuwenhuizen @ 2020-10-08  6:26 UTC (permalink / raw)
  To: 43860

[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]

Hi!

This patch disables 27 additional tests for the Hurd, and enabled me to
build (a copy of) python-minimal natively

--8<---------------cut here---------------start------------->8---
/gnu/store/9xm1idqyvyyz6xcqaa20aw2p8ap9zxcj-python-hurd-minimal-3.8.2
--8<---------------cut here---------------end--------------->8---

That sounds bad, but Debian disables ~15 tests by default (varies per
platform), where we only disable test_socket, and 17 additional for the
Hurd:

    https://salsa.debian.org/cpython-team/python3/-/raw/python3.8/debian/rules

and our exclude sets have some overlap, but also some "underlap"...

It's tempting to do

--8<---------------cut here---------------start------------->8---
#:tests? ,(not (hurd-target?))
--8<---------------cut here---------------end--------------->8---

just like https://bugs.gnu.org/43857 suggests:

    "rather not fiddle too much with test suites until we have defined
     what’s available in the default build environment."

on the other hand, now some 350 tests run and pass.  (It would be nice
if Python had a less fragile test suite, or if packages (the GNU
standard?) defined a "smoke test" we could run.)

Then there is also this 2013 bug report in Debian

    https://bugs.debian.org/708652
    "hurd has several tests disabled because they hang the testsuite, at
     least on the buildds. These should be investigated..."

and we/they probably will, when someone finds the time.

One last thing: pushing this patch rebuilds world for the Hurd; probably
not the best timing to push today?  Ideas?

Greetings,
Janneke


[-- Attachment #2: 0001-gnu-python-Disable-failing-tests-for-the-Hurd.patch --]
[-- Type: text/x-patch, Size: 3079 bytes --]

From 66eb46ed2f7166bff6d17dcbfe64f195ec1bb6b3 Mon Sep 17 00:00:00 2001
From: "Jan (janneke) Nieuwenhuizen" <janneke@gnu.org>
Date: Wed, 7 Oct 2020 23:01:26 +0200
Subject: [PATCH] gnu: python: Disable failing tests for the Hurd.
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8

* gnu/packages/python.scm (python-3.8)[arguments]: When building for the Hurd,
disable more tests.
---
 gnu/packages/python.scm | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8f2651decf..43704bccae 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -395,7 +395,39 @@ data types.")
                 " --exclude test_mmap"
                 ;; test_socket may hang and eventually run out of memory
                 ;; on some systems: <https://bugs.python.org/issue34587>.
-                " test_socket")))
+                " test_socket"
+                ,@(if (hurd-target?)
+                      '(" test_posix"      ;multiple errors
+                        " test_time"
+                        " test_pty"
+                        " test_shutil"
+                        " test_tempfile"   ;chflags: invalid argument:
+                                           ;  tbv14c9t/dir0/dir0/dir0/test0.txt
+                        " test_asyncio"    ;runs over 10min
+                        " test_os"         ;stty: 'standard input':
+                                           ;  Inappropriate ioctl for device
+                        " test_openpty"    ;No such file or directory
+                        " test_selectors"  ;assertEqual(NUM_FDS // 2, len(fds))
+                                           ;  32752 != 4
+                        " test_compileall" ;multiple errors
+                        " test_poll"       ;list index out of range
+                        " test_subprocess" ;runs over 10min
+                        " test_asyncore"   ;multiple errors
+                        " test_threadsignals"
+                        " test_eintr"      ;Process return code is -14
+                        " test_io"         ;multiple errors
+                        " test_logging"
+                        " test_signal"
+                        " test_threading"  ;runs over 10min
+                        " test_flags"      ;ERROR
+                        " test_bidirectional_pty"
+                        " test_create_unix_connection"
+                        " test_unix_sock_client_ops"
+                        " test_open_unix_connection"
+                        " test_open_unix_connection_error"
+                        " test_read_pty_output"
+                        " test_write_pty")
+                      '()))))
        ((#:phases phases)
        `(modify-phases ,phases
           ,@(if (hurd-system?)
-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com


[-- Attachment #3: Type: text/plain, Size: 152 bytes --]


-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [bug#43860] [PATCH] gnu: python: Disable failing tests for the Hurd.
  2020-10-08  6:26 [bug#43860] [PATCH] gnu: python: Disable failing tests for the Hurd Jan Nieuwenhuizen
@ 2020-10-13 20:51 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2020-10-13 20:51 UTC (permalink / raw)
  To: Jan Nieuwenhuizen, 43860

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Jan Nieuwenhuizen <janneke@gnu.org> writes:

> Hi!
>
> This patch disables 27 additional tests for the Hurd, and enabled me to
> build (a copy of) python-minimal natively
>
> --8<---------------cut here---------------start------------->8---
> /gnu/store/9xm1idqyvyyz6xcqaa20aw2p8ap9zxcj-python-hurd-minimal-3.8.2
> --8<---------------cut here---------------end--------------->8---

Yaay!  I thought it would be much worse...

[...]

> One last thing: pushing this patch rebuilds world for the Hurd; probably
> not the best timing to push today?  Ideas?

It has been a few days, so I guess you can go ahead and push.  Hopefully
the build farm catches up quickly for those who haven't gotten around to
try the new Hurd VM yet (like me!).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-13 20:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08  6:26 [bug#43860] [PATCH] gnu: python: Disable failing tests for the Hurd Jan Nieuwenhuizen
2020-10-13 20:51 ` Marius Bakke

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git