From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SOsOHbpqjF9QSQAA0tVLHw (envelope-from ) for ; Sun, 18 Oct 2020 16:18:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KF7yGLpqjF8cCwAAB5/wlQ (envelope-from ) for ; Sun, 18 Oct 2020 16:18:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D14689402C2 for ; Sun, 18 Oct 2020 16:18:01 +0000 (UTC) Received: from localhost ([::1]:54416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUBNg-0007L8-JU for larch@yhetil.org; Sun, 18 Oct 2020 12:18:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUBGx-0007DY-Ts for guix-patches@gnu.org; Sun, 18 Oct 2020 12:11:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUBGw-0005uA-1a for guix-patches@gnu.org; Sun, 18 Oct 2020 12:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUBGv-0001ll-Su for guix-patches@gnu.org; Sun, 18 Oct 2020 12:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43976] [PATCH] Chicken build system + some example eggs Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Oct 2020 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43976 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: raingloom Cc: 43976@debbugs.gnu.org Received: via spool by 43976-submit@debbugs.gnu.org id=B43976.16030374296758 (code B ref 43976); Sun, 18 Oct 2020 16:11:01 +0000 Received: (at 43976) by debbugs.gnu.org; 18 Oct 2020 16:10:29 +0000 Received: from localhost ([127.0.0.1]:38937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUBGP-0001kw-6F for submit@debbugs.gnu.org; Sun, 18 Oct 2020 12:10:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUBGN-0001kk-7Q for 43976@debbugs.gnu.org; Sun, 18 Oct 2020 12:10:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45554) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUBGH-0005hu-Uo; Sun, 18 Oct 2020 12:10:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42238 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUBGH-0000ZN-EE; Sun, 18 Oct 2020 12:10:21 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201013105220.7606ee5a@riseup.net> Date: Sun, 18 Oct 2020 18:10:19 +0200 In-Reply-To: <20201013105220.7606ee5a@riseup.net> (raingloom@riseup.net's message of "Tue, 13 Oct 2020 10:52:20 +0200") Message-ID: <87mu0j347o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: NE2B4dpiajqD Hi! raingloom skribis: > Here it is, chicken-build-system. Woohoo, really nice! Great to welcome another Scheme in our home. :-) Overall the series LGTM. Inline below are a few suggestions for minor issues. > # What's broken > Cross-compilation has not been attempted beacuse the Go build system I > based this on does not support it either. That=E2=80=99s fine, it can come later if/when someone feels like it. > # Necessary improvements > The Go build system removes some references. I was not sure if this is > needed for Chicken, so for now I left it out. You can check the output of =E2=80=98guix size chicken-srfi-14=E2=80=99 (sa= y). If it contains things that shouldn=E2=80=99t be there, like GCC or whatever, then we should do something about it. [...] >>>From 502235505c75446758cc1932bd1ba333644423ca Mon Sep 17 00:00:00 2001 > From: raingloom > Date: Mon, 12 Oct 2020 04:11:59 +0200 > Subject: [PATCH 01/11] gnu: Added search paths for Chicken Scheme. > > * gnu/packages/chicken.scm (chicken): Added search paths > [native-search-paths]: added CHICKEN_REPOSITORY_PATH and CHICKEN_INCLUD= E_PATH [...] > + (native-search-paths > + (list (search-path-specification > + (variable "CHICKEN_REPOSITORY_PATH") > + ;; TODO extract binary version into a module level definitio= n. > + (files (list "var/lib/chicken/11"))) > + (search-path-specification > + (variable "CHICKEN_INCLUDE_PATH") > + (files '("share"))))) Is it just share/, not share/chicken/ or something? A Chicken-specific directory name would be better, but if that=E2=80=99s really what Chicken expects, then so be it. Otherwise LGTM! > From a734e591ad066c20a53f9d0f955716ba8422bac5 Mon Sep 17 00:00:00 2001 > From: raingloom > Date: Tue, 13 Oct 2020 09:26:52 +0200 > Subject: [PATCH 02/11] guix: Added chicken-build-system. > > * guix/build-system/chicken.scm: New file. > * guix/build/chicken-build-system.scm: New file. > * Makefile.am: Add them. Please mention it in doc/guix.texi under =E2=80=9CBuild Systems=E2=80=9D wi= th a paragraph explaining the basics, as is done for the other build systems. > --- /dev/null > +++ b/guix/build/chicken-build-system.scm > @@ -0,0 +1,103 @@ > +(define-module (guix build chicken-build-system) Please add the GPLv3+ copyright header. > +;; TODO how do we run tests??? > + > +;; TODO remove references You can remove the second TODO unless/until we have reasons to believe this has to be done. The first TODO is more problematic though. Is there a standard way to run tests? It would be great if you could skim the packages you added to see how they handle tests, so that =E2=80=98chicken-build-system=E2=80= =99 can have a =E2=80=98check=E2=80=99 phase that follows common practice. Otherwise LGTM! >>>From a7e3b91b76625e01eed749c2c83a94862e3ef738 Mon Sep 17 00:00:00 2001 > From: raingloom > Date: Tue, 13 Oct 2020 09:55:42 +0200 > Subject: [PATCH 04/11] gnu: Added imports for chicken eggs. > > * gnu/packages/chicken.scm: New module imports. Usually we=E2=80=99d import modules in the patch where we first make use of them. Otherwise one might think this patch has no effect. > + (home-page "http://wiki.call-cc.org/eggref/5/srfi-69") > + (synopsis "An implementation of SRFI 69 with SRFI 90 extensions") I think =E2=80=98guix lint=E2=80=99 won=E2=80=99t like that=E2=80=A6 > + (description > + "Hash table implementation and binary search") =E2=80=A6 and a full sentence here would be welcome. :-) https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.= html Same for the other packages. > + (url (string-append "https://code.call-cc.org/svn/chicken-e= ggs/" > + "release/5/srfi-14/tags/" version)) > + (revision 39057) > + (user-name "anonymous") > + (password ""))) > + (sha256 > + (base32 > + "0wjsqfwawh9bx6vvii1gwag166bxkflc0ib374fbws14914g2ac1")))) > + (build-system chicken-build-system) > + (arguments '(#:egg-name "srfi-14")) > + (home-page "http://wiki.call-cc.org/eggref/5/srfi-14") > + (synopsis "Character set library") > + (description > + "Character sets can be created, extended, tested for the membership= of > +a characters and be compared to other character sets") > + (license (license:non-copyleft > + "file://srfi-14.scm" > + "See end of srfi-14.scm in the distribution.")))) You can use instead of . The license looks weird indeed, but it looks like a valid free software license. The only discussion I found is at: . > From 52a27d11eb3d4d0ced3deda01fe901bf2f1937fd Mon Sep 17 00:00:00 2001 > From: raingloom > Date: Mon, 12 Oct 2020 04:19:46 +0200 > Subject: [PATCH 11/11] gnu: Added myself to chicken.scm copyright. > > --- > gnu/packages/chicken.scm | 1 + > 1 file changed, 1 insertion(+) Please do that along with your first changes to the file. That=E2=80=99s it. Could you send a v2? Thank you for working on it! Ludo=E2=80=99.