From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yK/yK0xbzV/oFgAA0tVLHw (envelope-from ) for ; Sun, 06 Dec 2020 22:29:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eNDkJ0xbzV9vaQAAB5/wlQ (envelope-from ) for ; Sun, 06 Dec 2020 22:29:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 78B8C9403D3 for ; Sun, 6 Dec 2020 22:29:32 +0000 (UTC) Received: from localhost ([::1]:38188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km2X5-0005AW-GP for larch@yhetil.org; Sun, 06 Dec 2020 17:29:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km2Ww-0005A3-FK for guix-patches@gnu.org; Sun, 06 Dec 2020 17:29:22 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1km2Vd-0002Vz-TK for guix-patches@gnu.org; Sun, 06 Dec 2020 17:29:22 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1km2Vd-00073p-Pe for guix-patches@gnu.org; Sun, 06 Dec 2020 17:28:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44922] [PATCH 0/6] Prometheus node exporter service enhancements Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Dec 2020 22:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44922 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 44922@debbugs.gnu.org Received: via spool by 44922-submit@debbugs.gnu.org id=B44922.160729364027090 (code B ref 44922); Sun, 06 Dec 2020 22:28:01 +0000 Received: (at 44922) by debbugs.gnu.org; 6 Dec 2020 22:27:20 +0000 Received: from localhost ([127.0.0.1]:51622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km2Uy-00072s-1l for submit@debbugs.gnu.org; Sun, 06 Dec 2020 17:27:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km2Uw-00072e-3J for 44922@debbugs.gnu.org; Sun, 06 Dec 2020 17:27:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44628) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km2Uq-0002MC-K1; Sun, 06 Dec 2020 17:27:12 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45582 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1km2Up-0005ba-Nq; Sun, 06 Dec 2020 17:27:12 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87zh31u1q0.fsf@cbaines.net> Date: Sun, 06 Dec 2020 23:27:10 +0100 In-Reply-To: <87zh31u1q0.fsf@cbaines.net> (Christopher Baines's message of "Sat, 28 Nov 2020 12:04:23 +0000") Message-ID: <87mtyq370h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.80 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 78B8C9403D3 X-Spam-Score: -2.80 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: Gxj9qRbk+X+m Hi, Christopher Baines skribis: > services: monitoring: Neaten up the Prometheus node exporter. > monitoring: Add user and group for the Prometheus node exporter. > services: monitoring: Use a log file for Prometheus node exporter. > doc: Remove redundant node exporter configuration from the example. > monitoring: Enable the Prometheus node exporter textfile collector. > monitoring: Support extra options for the Prometheus node exporter. ^ Should be =E2=80=9Cservices: prometheus-node-exporter: =E2=80=A6=E2=80=9D. Apart from that, on a quick look it LGTM. Go for it! Thanks, Ludo=E2=80=99.