From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KBRpI2AdB2DDWQAA0tVLHw (envelope-from ) for ; Tue, 19 Jan 2021 17:56:48 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cDYmH2AdB2CEeAAA1q6Kng (envelope-from ) for ; Tue, 19 Jan 2021 17:56:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F01AF9403A6 for ; Tue, 19 Jan 2021 17:56:47 +0000 (UTC) Received: from localhost ([::1]:48300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1vFG-0003BZ-Tw for larch@yhetil.org; Tue, 19 Jan 2021 12:56:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1udm-0006ZQ-C1 for guix-patches@gnu.org; Tue, 19 Jan 2021 12:18:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1udm-0006On-42 for guix-patches@gnu.org; Tue, 19 Jan 2021 12:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1udm-0001Ob-0E for guix-patches@gnu.org; Tue, 19 Jan 2021 12:18:02 -0500 Subject: bug#45953: [PATCH] environment: fix --root option with relative path Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 19 Jan 2021 17:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45953 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: JOULAUD =?UTF-8?Q?Fran=C3=A7ois?= Mail-Followup-To: 45953@debbugs.gnu.org, ludo@gnu.org, Francois.JOULAUD@radiofrance.com Received: via spool by 45953-done@debbugs.gnu.org id=D45953.16110766255290 (code D ref 45953); Tue, 19 Jan 2021 17:18:01 +0000 Received: (at 45953-done) by debbugs.gnu.org; 19 Jan 2021 17:17:05 +0000 Received: from localhost ([127.0.0.1]:51477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1ucr-0001NF-Gk for submit@debbugs.gnu.org; Tue, 19 Jan 2021 12:17:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1ucn-0001Mg-Ge for 45953-done@debbugs.gnu.org; Tue, 19 Jan 2021 12:17:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56580) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1uch-0006C4-Fs; Tue, 19 Jan 2021 12:16:55 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47648 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l1ucg-0006ip-VQ; Tue, 19 Jan 2021 12:16:55 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210118082300.phr55ee5chgwmptl@fjo-extia-HPdeb.example.avalenn.eu> Date: Tue, 19 Jan 2021 18:16:53 +0100 In-Reply-To: <20210118082300.phr55ee5chgwmptl@fjo-extia-HPdeb.example.avalenn.eu> ("JOULAUD =?UTF-8?Q?Fran=C3=A7ois?="'s message of "Mon, 18 Jan 2021 08:26:02 +0000") Message-ID: <87mtx4hmnu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45953-done@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F01AF9403A6 X-Spam-Score: -2.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZO0SHcvQD09f Hi, JOULAUD Fran=C3=A7ois skribis: > The path normalization of `--root` option of `guix environment` was > buggy as it appended full argument after normalized directory. This > patch fixes it. > > * guix/scripts/environment.scm: fix gc-root path normalization Good catch! I added a test, tweaked the commit log, and pushed: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D4d79f072cc7b502fc= 25486d514c9200ba684a596 Thanks, Ludo=E2=80=99.