From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GLoDFg/sEWBadgAA0tVLHw (envelope-from ) for ; Wed, 27 Jan 2021 22:41:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gKHCEQ/sEWDyUgAAB5/wlQ (envelope-from ) for ; Wed, 27 Jan 2021 22:41:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90EC79404C2 for ; Wed, 27 Jan 2021 22:41:18 +0000 (UTC) Received: from localhost ([::1]:53136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4tUz-0005b4-KB for larch@yhetil.org; Wed, 27 Jan 2021 17:41:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4tUk-0005aT-NZ for guix-patches@gnu.org; Wed, 27 Jan 2021 17:41:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4tUk-0001Kj-Ez for guix-patches@gnu.org; Wed, 27 Jan 2021 17:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4tUk-0007gW-Cf for guix-patches@gnu.org; Wed, 27 Jan 2021 17:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45972] [PATCH] Add julia-json with dependencies Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Jan 2021 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45972 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Received: via spool by 45972-submit@debbugs.gnu.org id=B45972.161178723829503 (code B ref 45972); Wed, 27 Jan 2021 22:41:02 +0000 Received: (at 45972) by debbugs.gnu.org; 27 Jan 2021 22:40:38 +0000 Received: from localhost ([127.0.0.1]:46388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4tUM-0007fn-A8 for submit@debbugs.gnu.org; Wed, 27 Jan 2021 17:40:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4tUK-0007fZ-P3 for 45972@debbugs.gnu.org; Wed, 27 Jan 2021 17:40:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56927) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4tUF-0001IH-FY; Wed, 27 Jan 2021 17:40:31 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51400 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l4tUE-0008LC-Vt; Wed, 27 Jan 2021 17:40:31 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87ft2xzu1g.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87wnvzwfgu.fsf@gnu.org> <87lfcfcmf3.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 =?UTF-8?Q?Pluvi=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 27 Jan 2021 23:40:28 +0100 In-Reply-To: <87lfcfcmf3.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> ("=?UTF-8?Q?Nicol=C3=B2?= Balzarotti"'s message of "Wed, 27 Jan 2021 00:23:44 +0100") Message-ID: <87mtwut34z.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45972@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 90EC79404C2 X-Spam-Score: -2.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: OYMS9AAauQzJ Hi, Nicol=C3=B2 Balzarotti skribis: > Almost all of Julia packages are under MIT (expat), I double checked and > they are fine. Also, 3 packages (out of 8) have been updated since my > submission, so I updated them now and guix lint does not complain anymore. Great. > This is the first batch, I finally decided to submit in small batches > the 100+ packages I have; you have been warned :D Oh, fun! :-) So, actually, we have a problem: > +(define-public julia-orderedcollections > + (package > + (name "julia-orderedcollections") > + (version "1.3.2") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/JuliaCollections/OrderedCollection= s.jl") > + (commit (string-append "v" version)))) > + (file-name "OrderedCollections") I was surprised that =E2=80=98guix lint=E2=80=99 doesn=E2=80=99t complain a= bout this file name, I thought it required the file name to match the package name and at least that=E2=80=99s the spirit (I=E2=80=99ll take a look). Anyway, I went ahead and replaced all these by (git-file-name name version) as is done elsewhere. But now the tests would fail like so: --8<---------------cut here---------------start------------->8--- starting phase `check' ERROR: LoadError: ArgumentError: Package Adapt not found in current path: - Run `import Pkg; Pkg.add("Adapt")` to install the Adapt package. --8<---------------cut here---------------end--------------->8--- My understanding is that the first patch expects the source file name to match the Julia package name. IMO, that shouldn=E2=80=99t be the case. Ca= n we either extract the Julia package name from metadata that=E2=80=99s in the package itself (?), or otherwise pass it to all the phases via =E2=80=98julia-build-system=E2=80=99? Sorry for not noticing earlier! Thanks, Ludo=E2=80=99.